chrome/browser/download/download_util.cc - Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_util.cc

Issue 9316116: Isolate initiation counts for downloads to their own histograms and improve (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Shift recording of UMA to before initiation in all cases. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/download/download_throttling_resource_handler.cc ('K') | « chrome/browser/download/download_util.h ('k') | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_util.cc

diff --git a/chrome/browser/download/download_util.cc b/chrome/browser/download/download_util.cc

index a851c852ed9f6549e674a0db04bccd3415780c0c..812a11d4b4f93db30f97f2bba4aff17b3782b103 100644

--- a/chrome/browser/download/download_util.cc

+++ b/chrome/browser/download/download_util.cc

@@ -628,9 +628,9 @@ void RecordShelfClose(int size, int in_progress, bool autoclose) {

}

-void RecordDownloadCount(ChromeDownloadCountTypes type) {

+void RecordDownloadSource(ChromeDownloadInitiationSources source) {

UMA_HISTOGRAM_ENUMERATION(

- "Download.CountsChrome", type, DOWNLOAD_COUNT_TYPES_LAST_ENTRY);

+ "Download.SourcesChrome", source, DOWNLOAD_INITIATION_SOURCES_LAST_ENTRY);

jar (doing other things) 2012/02/07 19:18:50 FYI: This sort of transition is good/common. You s

}

} // namespace download_util