Isolate initiation counts for downloads to their own histograms and improve

content/browser/tab_contents/tab_contents.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/tab_contents/tab_contents.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 927 matching lines @@
     const GURL& current_page_url = GetURL();
     if (dlm && current_page_url.is_valid()) {
       DownloadSaveInfo save_info;
       save_info.prompt_for_save_location = true;
       dlm->DownloadUrl(current_page_url,
                        GURL(),
                        "",
                        true,  // prefer_cache
                        save_info,
                        this);
-      download_stats::RecordDownloadCount(
-          download_stats::INITIATED_BY_SAVE_PACKAGE_FAILURE_COUNT);
+      download_stats::RecordDownloadSource(
+          download_stats::INITIATED_BY_SAVE_PACKAGE_FAILURE);
       return;
     }
   }
 
   Stop();
 
   // Create the save package and possibly prompt the user for the name to save
   // the page as. The user prompt is an asynchronous operation that runs on
   // another thread.
   save_package_ = new SavePackage(this);
@@ skipping 458 matching lines @@
 
 void TabContents::OnUpdateZoomLimits(int minimum_percent,
                                      int maximum_percent,
                                      bool remember) {
   minimum_zoom_percent_ = minimum_percent;
   maximum_zoom_percent_ = maximum_percent;
   temporary_zoom_settings_ = !remember;
 }
 
 void TabContents::OnSaveURL(const GURL& url) {
+  download_stats::RecordDownloadSource(
+      download_stats::INITIATED_BY_RENDERER_SAVE);

[cbentzel, 2012/02/06 19:57:29]

Perhaps INITIATED_BY_PEPPER_SAVE? I guess we don't differentiate here. 

[Randy Smith (Not in Mondays), 2012/02/07 18:20:18]

Yeah; from the browser process perspective the distinction is
ViewHostMsg_{DownloadUrl, SaveURLAs}.  I'm open to different names for the enum
values if you have them, but I don't feel certain enough in my own heart that
the only place we could ever get that IPC is from pepper to call it out to
pepper.  But if you do, I'll change it.

[cbentzel, 2012/02/07 18:29:32]

Right now it's only from Pepper. If you merge/rebase you'll see that I've
commented this function to indicate that as well.

[Randy Smith (Not in Mondays), 2012/02/07 19:28:14]

Done.

   DownloadManager* dlm = GetBrowserContext()->GetDownloadManager();
   DownloadSaveInfo save_info;
   save_info.prompt_for_save_location = true;
   dlm->DownloadUrl(url, GetURL(), "", true, save_info, this);
 }
 
 void TabContents::OnEnumerateDirectory(int request_id,
                                        const FilePath& path) {
   delegate_->EnumerateDirectory(this, request_id, path);
 }
@@ skipping 849 matching lines @@
   encoding_ = content::GetContentClient()->browser()->
       GetCanonicalEncodingNameByAliasName(encoding);
 }
 
 void TabContents::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = GetView()->CreateViewForWidget(rvh);
   // Can be NULL during tests.
   if (rwh_view)
     rwh_view->SetSize(GetView()->GetContainerSize());
 }