First pass at chrome_browser gyp simplification.

First pass at chrome_browser gyp simplification.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120526

[Emmanuel Saint-loubert-Bié, 2012-02-04 01:42:20]

Hi Lei,

This is first pass which eliminates such defunct cases as chromeos==1 when
use_aura==0, etc...

We can certainly consolidate some more.

-- Emmanuel

[Lei Zhang, 2012-02-04 01:58:15]

LGTM with some nits below.

Certainly. One step at a time.

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi
File build/common.gypi (left):

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi#oldco...
build/common.gypi:300: # TODO(dnicoara) Wayland build should have these
disabled, but
I think this note still applies to use_glib and use_x11.

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi#oldco...
build/common.gypi:320: # for Linux distributions and for Aura.
I'd put this part of the comment back. It is useful for say, Gentoo, to in the
support for GNOME keyring if they want.

https://chromiumcodereview.appspot.com/9316112/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://chromiumcodereview.appspot.com/9316112/diff/1/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:4314: }, { # !chromeos==0
nit, double space before '#'

[Emmanuel Saint-loubert-Bié, 2012-02-05 17:37:17]

Thanks.

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi
File build/common.gypi (left):

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi#oldco...
build/common.gypi:300: # TODO(dnicoara) Wayland build should have these
disabled, but
On 2012/02/04 01:58:15, Lei Zhang wrote:
> I think this note still applies to use_glib and use_x11.

Done.

https://chromiumcodereview.appspot.com/9316112/diff/1/build/common.gypi#oldco...
build/common.gypi:320: # for Linux distributions and for Aura.
On 2012/02/04 01:58:15, Lei Zhang wrote:
> I'd put this part of the comment back. It is useful for say, Gentoo, to in the
> support for GNOME keyring if they want.

Done.

https://chromiumcodereview.appspot.com/9316112/diff/1/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://chromiumcodereview.appspot.com/9316112/diff/1/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:4314: }, { # !chromeos==0
On 2012/02/04 01:58:15, Lei Zhang wrote:
> nit, double space before '#'

Done.

[commit-bot: I haz the power, 2012-02-05 17:37:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/9316112/4003

[commit-bot: I haz the power, 2012-02-05 20:16:23]

Change committed as 120526