linux: add a use_gold flag that defaults to on

linux: add a use_gold flag that defaults to on

Currently, gyp attempts to autodetect whether the linker supports
the --icf flag.  It's more predictable to just require the caller
to specify whether they're using gold.

As a first demonstration of this, drop LINKER_USES_ICF code in the
Chrome build.  (I'll follow up with a gyp patch to remove the
LINKER_USES_ICF stuff in gyp.)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121068

[Evan Martin, 2012-02-04 00:58:26]

I'd like to remove all the autodetection logic in gyp and instead just make it
caller-specified, like this.

[Lei Zhang, 2012-02-04 01:09:13]

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi#newco...
build/common.gypi:382: # linux_use_gold: whether to use build flags that rely on
gold.
how about "linux_use_gold_flags"

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi#newco...
build/common.gypi:1983: ['linux_use_gold==1', {
Do we need to take |release_valgrind_build| into account like we did in the
deleted block?

[Evan Martin, 2012-02-08 18:33:53]

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi#newco...
build/common.gypi:382: # linux_use_gold: whether to use build flags that rely on
gold.
On 2012/02/04 01:09:13, Lei Zhang wrote:
> how about "linux_use_gold_flags"

Done.

https://chromiumcodereview.appspot.com/9316110/diff/1/build/common.gypi#newco...
build/common.gypi:1983: ['linux_use_gold==1', {
On 2012/02/04 01:09:13, Lei Zhang wrote:
> Do we need to take |release_valgrind_build| into account like we did in the
> deleted block?

Fixed.

[Lei Zhang, 2012-02-08 19:16:46]

lgtm

[commit-bot: I haz the power, 2012-02-08 19:19:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/evan@chromium.org/9316110/4002

[commit-bot: I haz the power, 2012-02-08 22:04:59]

Change committed as 121068