Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4717)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 9316102: Update extension events, routing, and delivery to use user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index 22f93bbf70d00e040a5157a8c1e99753b64f8de3..cde6bbf98da96b1fb53dd0a5410de1a20e69d279 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -29,6 +29,7 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebConsoleMessage.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebUserGestureIndicator.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
#include "webkit/glue/image_resource_fetcher.h"
#include "webkit/glue/resource_fetcher.h"
@@ -39,6 +40,7 @@ using WebKit::WebConsoleMessage;
using WebKit::WebDataSource;
using WebKit::WebFrame;
using WebKit::WebURLRequest;
+using WebKit::WebUserGestureIndicator;
using WebKit::WebView;
using webkit_glue::ImageResourceFetcher;
using webkit_glue::ResourceFetcher;
@@ -216,7 +218,13 @@ void ExtensionHelper::OnExtensionResponse(int request_id,
void ExtensionHelper::OnExtensionMessageInvoke(const std::string& extension_id,
const std::string& function_name,
const ListValue& args,
- const GURL& event_url) {
+ const GURL& event_url,
+ bool user_caused) {
+ scoped_ptr<WebUserGestureIndicator> user_gesture;
+ if (user_caused) {
+ user_gesture.reset(
+ WebUserGestureIndicator::DefinitelyProcessingUserGesture());
+ }
extension_dispatcher_->v8_context_set().DispatchChromeHiddenMethod(
extension_id, function_name, args, render_view(), event_url);
}

Powered by Google App Engine
This is Rietveld 408576698