Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2873)

Unified Diff: chrome/renderer/extensions/extension_dispatcher.cc

Issue 9316102: Update extension events, routing, and delivery to use user gesture. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_dispatcher.cc
diff --git a/chrome/renderer/extensions/extension_dispatcher.cc b/chrome/renderer/extensions/extension_dispatcher.cc
index 88ba39b0dfaf6e1455252b19273b875896d5bf31..a66644a86128da2cf62a9f2de4e2be3d1c67fb97 100644
--- a/chrome/renderer/extensions/extension_dispatcher.cc
+++ b/chrome/renderer/extensions/extension_dispatcher.cc
@@ -30,6 +30,7 @@
#include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityPolicy.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebUserGestureIndicator.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
#include "ui/base/resource/resource_bundle.h"
#include "v8/include/v8.h"
@@ -46,6 +47,7 @@ using WebKit::WebDocument;
using WebKit::WebFrame;
using WebKit::WebSecurityPolicy;
using WebKit::WebString;
+using WebKit::WebUserGestureIndicator;
using WebKit::WebVector;
using WebKit::WebView;
using content::RenderThread;
@@ -157,7 +159,14 @@ void ExtensionDispatcher::OnSetFunctionNames(
void ExtensionDispatcher::OnMessageInvoke(const std::string& extension_id,
const std::string& function_name,
const ListValue& args,
- const GURL& event_url) {
+ const GURL& event_url,
+ bool user_caused) {
+ scoped_ptr<WebUserGestureIndicator> user_gesture;
+ if (user_caused) {
+ user_gesture.reset(
+ WebUserGestureIndicator::DefinitelyProcessingUserGesture());
+ }
+
v8_context_set_.DispatchChromeHiddenMethod(
extension_id, function_name, args, NULL, event_url);

Powered by Google App Engine
This is Rietveld 408576698