Update extension events, routing, and delivery to use user gesture.

chrome/browser/extensions/extension_event_router.h

Index: chrome/browser/extensions/extension_event_router.h
diff --git a/chrome/browser/extensions/extension_event_router.h b/chrome/browser/extensions/extension_event_router.h
index 6624d98efdf0a1dc2a83a6b6d04c3eefc7f00ea3..45f80c8655b200d6a79fc06d1dbb2c8a89cb89ff 100644
--- a/chrome/browser/extensions/extension_event_router.h
+++ b/chrome/browser/extensions/extension_event_router.h
@@ -34,7 +34,8 @@ class ExtensionEventRouter : public content::NotificationObserver {
                             const std::string& extension_id,
                             const std::string& event_name,
                             const std::string& event_args,
-                            const GURL& event_url);
+                            const GURL& event_url,
+                            bool user_caused = false);

[Aaron Boodman, 2012/02/03 20:18:47]

I suggest consistently using the term 'user_gesture' since it has a specific
security meaning in browsers. It's more self-documenting that way.

[Aaron Boodman, 2012/02/03 20:18:47]

Also, consider using an enum for this flag, like:

enum UserGesture {
  IsUserGesture
  NotUserGesture
}

This might make the code more readable than the boolean flag.

[Matt Perry, 2012/02/03 20:34:41]

Default arguments are forbidden by the style guide.

[Greg Billock, 2012/02/03 22:57:56]

My plan was to only set the gesture indicator when the flag is on. Shall I
instead make an enum (including a "UnknownUserGesture" value) and make it always
use the passed gesture indicator unless it is unknown? (WebKit has three: Yes,
No, and Possible)

[Greg Billock, 2012/02/06 22:58:01]

Done.

[Greg Billock, 2012/02/06 22:58:01]

Done.

[Greg Billock, 2012/02/06 22:58:01]

Done.

 
   explicit ExtensionEventRouter(Profile* profile);
   virtual ~ExtensionEventRouter();
@@ -67,7 +68,8 @@ class ExtensionEventRouter : public content::NotificationObserver {
       const std::string& event_name,
       const std::string& event_args,
       Profile* restrict_to_profile,
-      const GURL& event_url);
+      const GURL& event_url,
+      bool user_caused = false);
 
   // Same as above, except only send the event to the given extension.
   virtual void DispatchEventToExtension(
@@ -75,7 +77,8 @@ class ExtensionEventRouter : public content::NotificationObserver {
       const std::string& event_name,
       const std::string& event_args,
       Profile* restrict_to_profile,
-      const GURL& event_url);
+      const GURL& event_url,
+      bool user_caused = false);
 
   // Send different versions of an event to extensions in different profiles.
   // This is used in the case of sending one event to extensions that have
@@ -89,7 +92,8 @@ class ExtensionEventRouter : public content::NotificationObserver {
       const std::string& event_args,
       Profile* restrict_to_profile,
       const std::string& cross_incognito_args,
-      const GURL& event_url);
+      const GURL& event_url,
+      bool user_caused = false);
 
   // Record the Event Ack from the renderer. (One less event in-flight.)
   void OnExtensionEventAck(const std::string& extension_id);