Update extension events, routing, and delivery to use user gesture.

chrome/browser/extensions/extension_message_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_message_service.h"
 
 #include "base/atomic_sequence_num.h"
 #include "base/json/json_writer.h"
 #include "base/stl_util.h"
 #include "base/values.h"
@@ skipping 59 matching lines @@
   args.Set(0, Value::CreateIntegerValue(dest_port_id));
   args.Set(1, Value::CreateStringValue(channel_name));
   args.Set(2, Value::CreateStringValue(tab_json));
   args.Set(3, Value::CreateStringValue(source_extension_id));
   args.Set(4, Value::CreateStringValue(target_extension_id));
   CHECK(port.sender);
   port.sender->Send(
       new ExtensionMsg_MessageInvoke(
           port.routing_id,
           target_extension_id,
-          ExtensionMessageService::kDispatchOnConnect, args, GURL()));
+          ExtensionMessageService::kDispatchOnConnect, args, GURL(), false));

[Aaron Boodman, 2012/02/29 01:20:37]

In these cases where you have to use a boolean constant, it's still nice to add
an inline comment describing the meaning:

GURL(),
false);  // not in a user gesture

[Greg Billock, 2012/02/29 17:58:08]

Good call. Done.

On 2012/02/29 01:20:37, Aaron Boodman wrote:

 }
 
 static void DispatchOnDisconnect(
     const ExtensionMessageService::MessagePort& port, int source_port_id,
     bool connection_error) {
   ListValue args;
   args.Set(0, Value::CreateIntegerValue(source_port_id));
   args.Set(1, Value::CreateBooleanValue(connection_error));
   port.sender->Send(new ExtensionMsg_MessageInvoke(port.routing_id,
-      "", ExtensionMessageService::kDispatchOnDisconnect, args, GURL()));
+      "", ExtensionMessageService::kDispatchOnDisconnect, args, GURL(), false));
 }
 
 static void DispatchOnMessage(const ExtensionMessageService::MessagePort& port,
                               const std::string& message, int target_port_id) {
   port.sender->Send(
       new ExtensionMsg_DeliverMessage(
           port.routing_id, target_port_id, message));
 }
 
 static content::RenderProcessHost* GetExtensionProcess(Profile* profile,
@@ skipping 277 matching lines @@
 
     if (current->second->opener.sender == sender) {
       CloseChannelImpl(current, GET_CHANNEL_OPENER_ID(current->first),
                        notify_other_port);
     } else if (current->second->receiver.sender == sender) {
       CloseChannelImpl(current, GET_CHANNEL_RECEIVERS_ID(current->first),
                        notify_other_port);
     }
   }
 }