Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: chrome/browser/resources/options2/pref_ui.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/pref_ui.js
diff --git a/chrome/browser/resources/options2/pref_ui.js b/chrome/browser/resources/options2/pref_ui.js
index cbe3bd4895281f5e0db3ad32170f805e46f1623c..bbb248c321d7b6b2066b9066725b1b1e4f3a31b3 100644
--- a/chrome/browser/resources/options2/pref_ui.js
+++ b/chrome/browser/resources/options2/pref_ui.js
@@ -31,7 +31,7 @@ cr.define('options', function() {
// 'other'.
delete el.disabledReasons['other'];
if (Object.keys(el.disabledReasons).length > 0)
- console.error("Element is not disabled but should be");
+ console.error('Element is not disabled but should be');
}
if (disabled) {
el.disabledReasons[reason] = true;
@@ -103,7 +103,7 @@ cr.define('options', function() {
if (self.customChangeHandler(e))
return;
var value = self.inverted_pref ? !self.checked : self.checked;
- switch(self.valueType) {
+ switch (self.valueType) {
case 'number':
Preferences.setIntegerPref(self.pref,
Number(value), self.metric);
@@ -543,7 +543,7 @@ cr.define('options', function() {
return;
}
- switch(self.dataType) {
+ switch (self.dataType) {
case 'number':
Preferences.setIntegerPref(self.pref,
self.options[self.selectedIndex].value, self.metric);
@@ -629,7 +629,7 @@ cr.define('options', function() {
// Listen to user events.
this.addEventListener('change',
function(e) {
- switch(self.dataType) {
+ switch (self.dataType) {
case 'number':
Preferences.setIntegerPref(self.pref, self.value, self.metric);
break;
« no previous file with comments | « chrome/browser/resources/options2/password_manager_list.js ('k') | chrome/browser/resources/options2/search_engine_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698