Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 9316086: Fix JavaScript errors in options2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: new violations found after rebase Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options2/options.js ('k') | chrome/browser/resources/options2/password_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/options_page.js
diff --git a/chrome/browser/resources/options2/options_page.js b/chrome/browser/resources/options2/options_page.js
index c316d13ede663888c806201b4f3604231d811637..0482f70e5c899e39dbfbbf9c91405f4e97a12220 100644
--- a/chrome/browser/resources/options2/options_page.js
+++ b/chrome/browser/resources/options2/options_page.js
@@ -10,7 +10,7 @@ cr.define('options', function() {
* Base class for options page.
* @constructor
* @param {string} name Options page name.
- * @param {string} title Options page title, used for navigation bar
+ * @param {string} title Options page title, used for navigation bar.
* @extends {EventTarget}
*/
function OptionsPage(name, title, pageDivName) {
@@ -200,7 +200,7 @@ cr.define('options', function() {
* according to which subpage is topmost and visible.
* @private
*/
- OptionsPage.updateSubpageBackdrop_ = function () {
+ OptionsPage.updateSubpageBackdrop_ = function() {
var topmostPage = OptionsPage.getTopmostVisibleNonOverlayPage_();
var nestingLevel = topmostPage ? topmostPage.nestingLevel : 0;
@@ -220,7 +220,7 @@ cr.define('options', function() {
* or the old scroll position a previously hidden subpage becomes visible).
* @private
*/
- OptionsPage.updateScrollPosition_ = function () {
+ OptionsPage.updateScrollPosition_ = function() {
var topmostPage = OptionsPage.getTopmostVisibleNonOverlayPage_();
var nestingLevel = topmostPage ? topmostPage.nestingLevel : 0;
@@ -575,8 +575,8 @@ cr.define('options', function() {
* @private
*/
OptionsPage.setPageFrozenAtLevel_ = function(freeze, level) {
- var container = level == 0 ? $('page-container')
- : $('subpage-sheet-container-' + level);
+ var container = level == 0 ? $('page-container') :
+ $('subpage-sheet-container-' + level);
if (container.classList.contains('frozen') == freeze)
return;
@@ -759,7 +759,7 @@ cr.define('options', function() {
/**
* Updates the given frozen element to match the horizontal scroll position.
- * @param {HTMLElement} e The frozen element to update
+ * @param {HTMLElement} e The frozen element to update.
* @private
*/
OptionsPage.updateFrozenElementHorizontalPosition_ = function(e) {
@@ -1084,8 +1084,8 @@ cr.define('options', function() {
/**
* Checks whether this page is an ancestor of the given page in terms of
* subpage nesting.
- * @param {OptionsPage} page
- * @return {boolean} True if this page is nested under |page|
+ * @param {OptionsPage} page The potential descendent of this page.
+ * @return {boolean} True if |page| is nested under this page.
*/
isAncestorOfPage: function(page) {
var parent = page.parentPage;
@@ -1099,7 +1099,7 @@ cr.define('options', function() {
/**
* Whether it should be possible to show the page.
- * @return {boolean} True if the page should be shown
+ * @return {boolean} True if the page should be shown.
*/
canShowPage: function() {
return true;
« no previous file with comments | « chrome/browser/resources/options2/options.js ('k') | chrome/browser/resources/options2/password_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698