Fix JavaScript errors in options2

chrome/browser/resources/options2/intents_list.js

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(gbillock): refactor this together with CookiesList once we have
 // a better sense from UX design what it'll look like and so what'll be shared.
 cr.define('options', function() {
   const DeletableItemList = options.DeletableItemList;
   const DeletableItem = options.DeletableItem;
   const ArrayDataModel = cr.ui.ArrayDataModel;
   const ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
@@ skipping 218 matching lines @@
      * @type {number}
      */
     get selectedIndex() {
       return this.selectedIndex_;
     },
 
     /**
      * Set the currently selected intents node ("intents bubble") index to
      * @{code itemIndex}, unselecting any previously selected node first.
      * @param {number} itemIndex The index to set as the selected index.
-     * TODO: KILL THIS
      */
+    // TODO: KILL THIS
     set selectedIndex(itemIndex) {
       // Get the list index up front before we change anything.
       var index = this.list.getIndexOfListItem(this);
       // Unselect any previously selected item.
       if (this.selectedIndex_ >= 0) {
         var item = this.itemList_[this.selectedIndex_];
         if (item && item.div)
           item.div.removeAttribute('selected');
       }
       // Special case: decrementing -1 wraps around to the end of the list.
@@ skipping 118 matching lines @@
         // Help out screen readers and such: this is a clickable thing.
         div.setAttribute('role', 'button');
 
         var divAction = item.ownerDocument.createElement('div');
         divAction.className = 'intents-item-action';
         divAction.textContent = this.data.action;
         div.appendChild(divAction);
 
         var divTypes = item.ownerDocument.createElement('div');
         divTypes.className = 'intents-item-types';
-        var text = "";
-        for (var i = 0; i < this.data.types.length; ++i) {
-          if (text != "")
-            text += ", ";
-          text += this.data.types[i];
-        }
-        divTypes.textContent = text;
+        divTypes.textContent = this.data.types.join(', ');
         div.appendChild(divTypes);
 
         var divUrl = item.ownerDocument.createElement('div');
         divUrl.className = 'intents-item-url';
         divUrl.textContent = this.data.url;
         div.appendChild(divUrl);
 
         var index = item.appendItem(this, div);
         div.onclick = function() {
           if (item.selectedIndex == index)
@@ skipping 301 matching lines @@
       parent.clear();
       this.addByParent_(parent, 0, children);
       parent.endBatchUpdates();
     },
   };
 
   return {
     IntentsList: IntentsList
   };
 });