Issue 9316084: Switch back to 'int' instead of uint32 and call CancelIo before closing the socket handle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9316084: Switch back to 'int' instead of uint32 and call CancelIo before closing the socket handle. (Closed)

Created:
8 years, 10 months ago by tommi (sloooow) - chröme

Modified:
8 years, 10 months ago

Reviewers:
no longer working on chromium

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch back to 'int' instead of uint32 and call CancelIo before closing the socket handle. BUG=112092 TBR=darin (tbr for the sync_socket_win change) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120320

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -5 lines)			Patch
M	base/sync_socket_win.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	content/renderer/media/audio_device.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	content/renderer/media/audio_input_device.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

no longer working on chromium

LGTM. Does this CL fixes the crash or is it not verified yet? BR, /SX

8 years, 10 months ago (2012-02-03 08:49:36 UTC) #2

tommi (sloooow) - chröme

Not verified yet. I haven't been able to repro or find the definite cause. On ...

8 years, 10 months ago (2012-02-03 09:09:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/9316084/1

8 years, 10 months ago (2012-02-03 11:25:53 UTC) #4

Change committed as 120320

Expand Messages | Collapse Messages