Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host.h

Issue 9316077: Enable audio/video tag in content_shell (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to CR Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host.h
diff --git a/content/browser/renderer_host/media/audio_renderer_host.h b/content/browser/renderer_host/media/audio_renderer_host.h
index d24dfdbe1487bc932b10491ed2c389f1befa8dfd..7ff1194fcbcb6b8423472e04259ed2aeb8e56df1 100644
--- a/content/browser/renderer_host/media/audio_renderer_host.h
+++ b/content/browser/renderer_host/media/audio_renderer_host.h
@@ -178,10 +178,18 @@ class CONTENT_EXPORT AudioRendererHost
// event is received.
AudioEntry* LookupByController(media::AudioOutputController* controller);
- // Return resource_context_->media_observer() or a cached copy thereof.
- // This is necessary because resource_context_ can be destructed before all
+ // Notifies the MediaObserver about various audio stream events.
+ void OnSetAudioStreamPlaying(int stream_id, bool playing);
+ void OnSetAudioStreamStatus(int stream_id, const std::string& status);
+ void OnSetAudioStreamVolume(int stream_id, double volume);
+ void OnDeleteAudioStream(int stream_id);
+
+ // Return the MediaObserver from |resource_context_| or a cached copy thereof.
+ // This is necessary because |resource_context_| can be destructed before all
// AudioEntries have been deleted. The MediaObserver's lifetime is tied to
// that of the IO thread, so this is safe.
+ // TODO(vrk): Saving the |media_observer_| pointer is a hack! We shouldn't
+ // need to do this and the field should be removed. See crbug.com/116906.
content::MediaObserver* GetMediaObserver();
// A map of stream IDs to audio sources.

Powered by Google App Engine
This is Rietveld 408576698