Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 9316052: Log IP/port of host as well as client in Me2Me host (Closed)

Created:
8 years, 10 months ago by Lambros
Modified:
8 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Log IP/port of host as well as client in Me2Me host BUG=112327 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120159

Patch Set 1 #

Total comments: 16

Patch Set 2 : s/IpAddress/RouteChange s/end_point/remote_end_point and other nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -44 lines) Patch
M remoting/host/chromoting_host.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M remoting/host/client_session.h View 1 2 chunks +10 lines, -6 lines 0 comments Download
M remoting/host/client_session.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M remoting/host/host_event_logger.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/host/host_event_logger.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/host/host_status_observer.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M remoting/protocol/connection_to_client.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M remoting/protocol/connection_to_client.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_session.cc View 1 1 chunk +15 lines, -3 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M remoting/protocol/session.h View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lambros
8 years, 10 months ago (2012-02-02 00:37:46 UTC) #1
Sergey Ulanov
Some nits. LGTM otherwise. http://codereview.chromium.org/9316052/diff/1/remoting/host/client_session.h File remoting/host/client_session.h (right): http://codereview.chromium.org/9316052/diff/1/remoting/host/client_session.h#newcode52 remoting/host/client_session.h:52: virtual void OnSessionIpAddress(ClientSession* client, Rename ...
8 years, 10 months ago (2012-02-02 01:10:23 UTC) #2
Lambros
http://codereview.chromium.org/9316052/diff/1/remoting/host/client_session.h File remoting/host/client_session.h (right): http://codereview.chromium.org/9316052/diff/1/remoting/host/client_session.h#newcode52 remoting/host/client_session.h:52: virtual void OnSessionIpAddress(ClientSession* client, On 2012/02/02 01:10:23, sergeyu wrote: ...
8 years, 10 months ago (2012-02-02 01:48:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/9316052/1003
8 years, 10 months ago (2012-02-02 01:48:31 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-02 04:07:54 UTC) #5
Change committed as 120159

Powered by Google App Engine
This is Rietveld 408576698