net: Explicitly close a file stream in UploadDataStream.

net: Explicitly close a file stream in UploadDataStream.

This is to make it clear that a file stream is closed there,
hence file access is performed. Add ScopedIOAllowIO as well.

BUG=72001
TEST=net_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120134

[eroman, 2012-02-01 21:43:28]

lgtm

http://codereview.chromium.org/9316048/diff/1/net/base/upload_data_stream.cc
File net/base/upload_data_stream.cc (right):

http://codereview.chromium.org/9316048/diff/1/net/base/upload_data_stream.cc#...
net/base/upload_data_stream.cc:171: element_file_stream_.Close();
The call to Close() isn't strictly necessary right?
Destruction should implicitly close it too.

[satorux1, 2012-02-01 21:46:09]

http://codereview.chromium.org/9316048/diff/1/net/base/upload_data_stream.cc
File net/base/upload_data_stream.cc (right):

http://codereview.chromium.org/9316048/diff/1/net/base/upload_data_stream.cc#...
net/base/upload_data_stream.cc:171: element_file_stream_.Close();
On 2012/02/01 21:43:28, eroman wrote:
> The call to Close() isn't strictly necessary right?
> Destruction should implicitly close it too.

you are right, but wanted to make it clear that file access is performed here. I
also plan to make file closing asynchronous in the upcoming patches.

btw, element_file_stream_.Close() should have been
element_file_stream_->Close(). patch set 2 fixed this.

[eroman, 2012-02-01 21:47:47]

lgtm

[commit-bot: I haz the power, 2012-02-01 22:32:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/satorux@chromium.org/9316048/6001

[commit-bot: I haz the power, 2012-02-02 00:36:27]

Change committed as 120134