Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/valgrind/chrome_tests.py

Issue 9316020: Disable unit_tests for memcheck/Mac by checking in chrome_tests.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.py
index ae3696b65673800500efef0ca417de7e8248a9e1..3c8b4d32e39f95a52033cf3deb38f68e20ac5a61 100755
--- a/tools/valgrind/chrome_tests.py
+++ b/tools/valgrind/chrome_tests.py
@@ -281,6 +281,12 @@ class ChromeTests:
return self.SimpleTest("webkit", "test_shell_tests")
def TestUnit(self):
+ # crbug 51716
Lei Zhang 2012/02/01 01:51:57 nit: can you do http://crbug.com/51716 ?
Brad Chen 2012/02/01 02:02:50 Done.
+ # Disabling all unit tests
+ # Problems reappeared after r119922
+ if common.IsMac() and (self._options.valgrind_tool == "memcheck"):
+ logging.warning("unit_tests are disabled for memcheck on MacOS.")
+ return 0;
return self.SimpleTest("chrome", "unit_tests")
def TestUIUnit(self):
« no previous file with comments | « no previous file | tools/valgrind/gtest_exclude/unit_tests.gtest_mac.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698