Don't show the app error page for bookmark apps.

Don't show the app error page for bookmark apps.

BUG=110402
TEST=Launching the default YouTube and Search apps should not show the "<app name> is unreacheable" page when Chrome is offline
R=miket@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120103

[miket_OOO, 2012-02-01 17:13:44]

Yes.

[miket_OOO, 2012-02-01 17:15:13]

LGTM (still not clear to me whether I can approve as a non-committer).

[commit-bot: I haz the power, 2012-02-01 18:13:09]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Mihai Parparita -not on Chrome, 2012-02-01 18:16:46]

Anthony, can you LGTM?

[asargent_no_longer_on_chrome, 2012-02-01 18:20:41]

lgtm

[commit-bot: I haz the power, 2012-02-01 18:25:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/9316019/1

[commit-bot: I haz the power, 2012-02-01 18:54:42]

Try job failure for 9316019-1 on linux_clang for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[Mihai Parparita -not on Chrome, 2012-02-01 19:23:22]

+maruel

The tryjob (
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...)
failed with this error, which makes it seem like the bot is in a hosed
state:

4>________ running 'svn update
/mnt/data/b/build/slave/linux_clang/build/src/third_party/valgrind
--revision 120081 --non-interactive --force --accept postpone
--ignore-externals' in '/mnt/data/b/build/slave/linux_clang/build'
4>svn: Can't create directory
'/mnt/data/b/build/slave/linux_clang/build/src/third_party/valgrind/linux_x64/.svn':
File exists
Error: Can't update/checkout
/mnt/data/b/build/slave/linux_clang/build/src/chrome/browser/autofill/internal
if an unversioned directory is present. Delete the directory and try
again.


Mihai

On Wed, Feb 1, 2012 at 10:54 AM, <commit-bot@chromium.org> wrote:

> Try job failure for 9316019-1 on linux_clang for step "update".
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_**clang&number=8204<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clang&number=8204>
>
> Step "update" is always a major failure.
> Look at the try server FAQ for more details.
>
>
http://codereview.chromium.**org/9316019/<http://codereview.chromium.org/9316...
>

[commit-bot: I haz the power, 2012-02-01 19:23:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mihaip@chromium.org/9316019/1

[commit-bot: I haz the power, 2012-02-01 21:16:13]

Change committed as 120103