Remove wow_helper.exe from Win 7 and higher.

Remove wow_helper.exe from Win 7 and higher.


BUG=104418
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120027

[grt (UTC plus 2), 2012-01-31 21:27:55]

Please check with rvargas to see if he thinks the helper is needed for WS08 as
it is for Vista, but not for WS08R2 as with Win7.

https://chromiumcodereview.appspot.com/9316007/diff/1/chrome/installer/setup/...
File chrome/installer/setup/install_worker.cc (right):

https://chromiumcodereview.appspot.com/9316007/diff/1/chrome/installer/setup/...
chrome/installer/setup/install_worker.cc:759: base::win::GetVersion() <=
base::win::VERSION_VISTA) {
I think you're about to shave a yak.  Server 2008 is nearly Vista, whereas
Server 2008 R2 is nearly Win7.  windows_version.cc doesn't handle this
distinction, but I suspect the difference matters here: wow_helper is probably
needed for Server 2008 but not Server 2008 R2.  I think the right thing to do is
to give OSInfo::OSInfo in windows_version.cc the power to distinguish these. 
See
http://msdn.microsoft.com/en-us/library/windows/desktop/ms724833(v=vs.85).aspx
for details.

[arthurhsu, 2012-01-31 21:38:38]

Ricardo, can you help answer if wow_helper.exe is needed for Server 2008?

[rvargas (doing something else), 2012-01-31 21:56:56]

On 2012/01/31 21:38:38, arthurhsu wrote:
> Ricardo, can you help answer if wow_helper.exe is needed for Server 2008?

The theory says that we should not need wow_helper for any version of 2k8. The
code that runs wow_helper performs the same check (<= vista).

[arthurhsu, 2012-01-31 22:07:35]

http://codereview.chromium.org/9316007/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/9316007/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:759: base::win::GetVersion() <=
base::win::VERSION_VISTA) {
On 2012/01/31 21:27:56, grt wrote:
> I think you're about to shave a yak.  Server 2008 is nearly Vista, whereas
> Server 2008 R2 is nearly Win7.  windows_version.cc doesn't handle this
> distinction, but I suspect the difference matters here: wow_helper is probably
> needed for Server 2008 but not Server 2008 R2.  I think the right thing to do
is
> to give OSInfo::OSInfo in windows_version.cc the power to distinguish these. 
> See
>
http://msdn.microsoft.com/en-us/library/windows/desktop/ms724833%28v=vs.85%29...
> for details.

Please refer to Ricardo's reply.  BTW, I copied the condition check that Ricardo
mentioned from chromium/src/sandbox/src/interception.cc:427.

[grt (UTC plus 2), 2012-02-01 02:12:17]

LGTM

http://codereview.chromium.org/9316007/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/9316007/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:759: base::win::GetVersion() <=
base::win::VERSION_VISTA) {
On 2012/01/31 22:07:35, arthurhsu wrote:
> Please refer to Ricardo's reply.  BTW, I copied the condition check that
Ricardo
> mentioned from chromium/src/sandbox/src/interception.cc:427.

Cool, thanks for the confirmation, Ricardo.

[commit-bot: I haz the power, 2012-02-01 02:23:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/arthurhsu@chromium.org/9316007/1

[commit-bot: I haz the power, 2012-02-01 04:09:30]

Change committed as 120027