Aura: Rework window mode flags to compact/overlapping/managed

ash/shell.h

Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index ab4da7bd3874e653d689f61f9eb3ace9cb1108b3..38bbcc27b3d67cd2a672295e6cb41b2f143de79d 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -65,11 +65,13 @@ class WorkspaceController;
 class ASH_EXPORT Shell {
  public:
   // In compact window mode we fill the screen with a single maximized window,
-  // similar to ChromeOS R17 and earlier.  In normal mode we have draggable
-  // windows.
+  // similar to ChromeOS R17 and earlier.  In overlapping mode we have draggable
+  // windows.  In managed mode the workspace arranges windows for the user.
   enum WindowMode {
-    NORMAL_MODE,
-    COMPACT_MODE
+    MODE_UNINITIALIZED = -1,

[sky, 2012/01/31 21:44:54]

Do we really need MODE_UNINITIALIZED?

[James Cook, 2012/01/31 22:26:28]

Not really.  Removed.

+    MODE_COMPACT,
+    MODE_MANAGED,
+    MODE_OVERLAPPING,
   };
 
   // A shell must be explicitly created so that it can call |Init()| with the
@@ -107,7 +109,7 @@ class ASH_EXPORT Shell {
   bool IsModalWindowOpen() const;
 
   // See enum WindowMode for details.
-  bool IsWindowModeCompact() const { return window_mode_ == COMPACT_MODE; }
+  bool IsWindowModeCompact() const;
 
   // Creates a default views::NonClientFrameView for use by windows in the
   // Ash environment.
@@ -158,7 +160,7 @@ class ASH_EXPORT Shell {
   // Initializes or re-initializes the layout managers and event filters needed
   // to support a given window mode and cleans up the unneeded ones.
   void SetupCompactWindowMode();
-  void SetupNormalWindowMode();
+  void SetupNonCompactWindowMode(bool managed);
 
   // Sets the LayoutManager of the container with the specified id to NULL. This
   // has the effect of deleting the current LayoutManager.