Aura: Rework window mode flags to compact/overlapping/managed

Aura: Rework window mode flags to compact/overlapping/managed

* Rename "normal" to "overlapping", since there was some confusion about whether or not compact mode is "normal"
* Remove "--aura-workspace-manager" flag in favor of "--aura-window-mode=managed", as this feature is not compatible with compact mode.
* Change about:flags Window mode to a three-way choice between modes

BUG=112139
TEST=aura_shell_unittests ShellTest, manual check of about:flags


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120035

[James Cook, 2012-01-31 20:07:52]

Scott, PTAL.

[sky, 2012-01-31 21:44:54]

http://codereview.chromium.org/9316005/diff/2001/ash/shell.cc
File ash/shell.cc (right):

http://codereview.chromium.org/9316005/diff/2001/ash/shell.cc#newcode493
ash/shell.cc:493: if (managed_mode) {
Can we look at window_mode_ rather than having a mysterious boolean param to
this function?

http://codereview.chromium.org/9316005/diff/2001/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/9316005/diff/2001/ash/shell.h#newcode71
ash/shell.h:71: MODE_UNINITIALIZED = -1,
Do we really need MODE_UNINITIALIZED?

[James Cook, 2012-01-31 22:26:28]

http://codereview.chromium.org/9316005/diff/2001/ash/shell.cc
File ash/shell.cc (right):

http://codereview.chromium.org/9316005/diff/2001/ash/shell.cc#newcode493
ash/shell.cc:493: if (managed_mode) {
On 2012/01/31 21:44:54, sky wrote:
> Can we look at window_mode_ rather than having a mysterious boolean param to
> this function?

Good idea.  Done.

http://codereview.chromium.org/9316005/diff/2001/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/9316005/diff/2001/ash/shell.h#newcode71
ash/shell.h:71: MODE_UNINITIALIZED = -1,
On 2012/01/31 21:44:54, sky wrote:
> Do we really need MODE_UNINITIALIZED?

Not really.  Removed.

[sky, 2012-01-31 22:58:55]

LGTM

[commit-bot: I haz the power, 2012-02-01 03:53:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9316005/6001

[commit-bot: I haz the power, 2012-02-01 05:10:38]

Change committed as 120035