Move common file path related methods between chrome & content to file_util. I reduced the 4 meth...

base/file_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains utility functions for dealing with the local
 // filesystem.
 
 #ifndef BASE_FILE_UTIL_H_
 #define BASE_FILE_UTIL_H_
 #pragma once
@@ skipping 44 matching lines @@
 BASE_EXPORT bool EnsureEndsWithSeparator(FilePath* path);
 
 // Convert provided relative path into an absolute path.  Returns false on
 // error. On POSIX, this function fails if the path does not exist.
 BASE_EXPORT bool AbsolutePath(FilePath* path);
 
 // Returns true if |parent| contains |child|. Both paths are converted to
 // absolute paths before doing the comparison.
 BASE_EXPORT bool ContainsPath(const FilePath& parent, const FilePath& child);
 
+// Appends the passed-in |number| between parenthesis to the |path| before
+// the file extension.
+BASE_EXPORT void AppendNumberToPath(FilePath* path, int number);
+
+// Appends the passed-in |suffix| to the |path|.
+BASE_EXPORT FilePath AppendSuffixToPath(const FilePath& path,
+                                        const FilePath::StringType& suffix);

[Evan Martin, 2012/01/31 21:23:44]

Why does one of these take a FilePath* and the other return a new FilePath?  I
think they both should behave like hte latter.

+
 //-----------------------------------------------------------------------------
 // Functions that involve filesystem access or modification:
 
 // Returns the number of files matching the current path that were
 // created on or after the given |file_time|.  Doesn't count ".." or ".".
 //
 // Note for POSIX environments: a file created before |file_time|
 // can be mis-detected as a newer file due to low precision of
 // timestmap of file creation time. If you need to avoid such
 // mis-detection perfectly, you should wait one second before
@@ skipping 306 matching lines @@
 // Append the data to |fd|. Does not close |fd| when done.
 BASE_EXPORT int WriteFileDescriptor(const int fd, const char* data, int size);
 #endif
 
 // Gets the current working directory for the process.
 BASE_EXPORT bool GetCurrentDirectory(FilePath* path);
 
 // Sets the current working directory for the process.
 BASE_EXPORT bool SetCurrentDirectory(const FilePath& path);
 
+// Attempts to find a number that can be appended to the |path| to make it
+// unique. If |path| does not exist, 0 is returned.  If it fails to find such
+// a number, -1 is returned. If |suffix| is not empty, also checks the
+// existence of it with the given suffix.
+BASE_EXPORT int GetUniquePathNumber(const FilePath& path,
+                                    const FilePath::StringType& suffix);
+
 #if defined(OS_POSIX)
 // Test that |path| can only be changed by a given user and members of
 // a given set of groups.
 // Specifically, test that all parts of |path| under (and including) |base|:
 // * Exist.
 // * Are owned by a specific user.
 // * Are not writable by all users.
 // * Are owned by a memeber of a given set of groups, or are not writable by
 //   their group.
 // * Are not symbolic links.
@@ skipping 237 matching lines @@
 BASE_EXPORT bool GetFileSystemType(const FilePath& path, FileSystemType* type);
 #endif
 
 }  // namespace file_util
 
 // Deprecated functions have been moved to this separate header file,
 // which must be included last after all the above definitions.
 #include "base/file_util_deprecated.h"
 
 #endif  // BASE_FILE_UTIL_H_