[Sync] Fix idempotency check for passwords datatype.

[Sync] Fix idempotency check for passwords datatype.

We do the same logic as in UpdateEntryWithEncryption in SetPasswordSpecifics
now. Added unit tests to ensure this doesn't happen again.

BUG=112402
TEST=sync_unit_tests --gtest_filter="*UpdatePasswordsData*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120264

[Nicolas Zea, 2012-02-02 18:14:29]

PTAL, this fixes the issue you found.

[rlarocque, 2012-02-02 18:55:31]

LGTM, with comment.

http://codereview.chromium.org/9315048/diff/1/chrome/browser/sync/internal_ap...
File chrome/browser/sync/internal_api/syncapi_unittest.cc (right):

http://codereview.chromium.org/9315048/diff/1/chrome/browser/sync/internal_ap...
chrome/browser/sync/internal_api/syncapi_unittest.cc:1797:
TEST_F(SyncManagerTest, UpdatePasswordsData) {
Could you split this into several different tests?  It looks like the parts
between each call to ResetUnsyncedEntry are mostly independent.

[Nicolas Zea, 2012-02-02 19:54:36]

Done. Committing.

http://codereview.chromium.org/9315048/diff/1/chrome/browser/sync/internal_ap...
File chrome/browser/sync/internal_api/syncapi_unittest.cc (right):

http://codereview.chromium.org/9315048/diff/1/chrome/browser/sync/internal_ap...
chrome/browser/sync/internal_api/syncapi_unittest.cc:1797:
TEST_F(SyncManagerTest, UpdatePasswordsData) {
On 2012/02/02 18:55:31, rlarocque wrote:
> Could you split this into several different tests?  It looks like the parts
> between each call to ResetUnsyncedEntry are mostly independent.

Done.

[commit-bot: I haz the power, 2012-02-02 19:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/9315048/1006

[commit-bot: I haz the power, 2012-02-02 21:58:35]

Try job failure for 9315048-1006 (retry) on win_rel for step "test_shell_tests".
It's a second try, previously, step "test_shell_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-02-02 22:06:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zea@chromium.org/9315048/1006

[commit-bot: I haz the power, 2012-02-03 01:06:52]

Try job failure for 9315048-1006 (retry) (retry) on win_rel for step
"test_shell_tests".
It's a second try, previously, step "test_shell_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...