Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 9315044: Get rid of <iostream> include in stack_trace_posix (forces a static initializer) (Closed)

Created:
8 years, 10 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 10 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Get rid of <iostream> include in stack_trace_posix (forces a static initializer) BUG=94925 TEST=sizes reports one less SI Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/debug/stack_trace_posix.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tyler Breisacher (Chromium)
8 years, 10 months ago (2012-02-01 23:46:41 UTC) #1
Evan Martin
LGTM On Wed, Feb 1, 2012 at 3:46 PM, <tbreisacher@chromium.org> wrote: > Reviewers: Evan Martin, ...
8 years, 10 months ago (2012-02-03 01:34:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9315044/1
8 years, 10 months ago (2012-02-03 01:40:40 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-03 04:02:20 UTC) #4
Change committed as 120278

Powered by Google App Engine
This is Rietveld 408576698