Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 9315015: Adds two new observer methods to allow code to be notified when a Window is added/removed from a ... (Closed)

Created:
8 years, 10 months ago by Ben Goodger (Google)
Modified:
8 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows. http://crbug.com/112131 TEST=see unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119976 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120025

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -49 lines) Patch
M ui/aura/root_window.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/root_window.cc View 1 5 chunks +29 lines, -23 lines 0 comments Download
M ui/aura/window.h View 1 2 chunks +5 lines, -10 lines 0 comments Download
M ui/aura/window.cc View 1 4 chunks +26 lines, -10 lines 0 comments Download
M ui/aura/window_observer.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
Currently we have code like this: class Foo { public: ~Foo() { RootWindow::GetInstance()->GetCompositor()->DoSomethingRelatedTo(window_->layer()); } private: ...
8 years, 10 months ago (2012-01-31 22:16:01 UTC) #1
sky
LGTM http://codereview.chromium.org/9315015/diff/1/ui/aura/window.cc File ui/aura/window.cc (right): http://codereview.chromium.org/9315015/diff/1/ui/aura/window.cc#newcode647 ui/aura/window.cc:647: Window::Windows::const_iterator it = children_.begin(); nit: put iterator inside ...
8 years, 10 months ago (2012-01-31 22:20:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/9315015/2003
8 years, 10 months ago (2012-02-01 02:28:49 UTC) #3
commit-bot: I haz the power
8 years, 10 months ago (2012-02-01 04:06:36 UTC) #4
Change committed as 120025

Powered by Google App Engine
This is Rietveld 408576698