RulesRegistry for declarative APIs.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/basictypes.h"
@@ skipping 18 matching lines @@
 #include "chrome/browser/accessibility/accessibility_extension_api.h"
 #include "chrome/browser/bookmarks/bookmark_extension_api.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_plugin_service_filter.h"
 #include "chrome/browser/download/download_extension_api.h"
 #include "chrome/browser/extensions/api/socket/socket_api_controller.h"
 #include "chrome/browser/extensions/app_notification_manager.h"
 #include "chrome/browser/extensions/apps_promo.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/crx_installer.h"
+#include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
 #include "chrome/browser/extensions/default_apps_trial.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_cookies_api.h"
 #include "chrome/browser/extensions/extension_data_deleter.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_global_error.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_input_ime_api.h"
 #include "chrome/browser/extensions/extension_management_api.h"
 #include "chrome/browser/extensions/extension_preference_api.h"
@@ skipping 1113 matching lines @@
     const Extension::NaClModuleInfo& module = extension->nacl_modules()[i];
     UnregisterNaClModule(module.url);
     nacl_modules_changed = true;
   }
 
   if (nacl_modules_changed)
     UpdatePluginListWithNaClModules();
 
   if (plugins_changed || nacl_modules_changed)
     PluginService::GetInstance()->PurgePluginListCache(profile_, false);
+
+  if (rules_registry_service_.get())
+    rules_registry_service_->OnExtensionUnloaded(extension->id());

[not at google - send to devlin, 2012/02/07 03:25:10]

Rather than this, have the RulesRegistryService listen to EXTENSION_UNLOADED
events.

git grep -w NOTIFICATION_EXTENSION_UNLOADED

[battre, 2012/02/07 18:45:33]

I had that before and removed it once I transferred ownership of the rules
registry service from the profile to the extension service. I think that given
the direct ownership I prefer the current implementation over some broadcasting
mechanism. Would you want to subscribe each RulesRegistry to
NOTIFICATION_EXTENSION_UNLOADED?

[not at google - send to devlin, 2012/02/07 23:54:57]

I agree that it's a shame we use a broadcasting mechanism for this sort of
stuff. IMO in general nicer design would be to have some object be responsible
for the installation of extensions (currently that's ExtensionService), then
anything that wants to be notified of that can register listeners on
ExtensionService directly.

I guess one problem with listener architecture in C++ is that lifetimes are more
difficult to express; you rely on ExtensionService to outlive the object which
is listening.

Which is presumably why they used an event bus architecture. It's also easier to
write, and grep for.

In any case, that's what we have. It shouldn't be a concern of ExtensionService
that the RulesRegistry wants to know when extensions are uninstalled.

So yeah, you'd want to subscribe RulesRegistry to
NOTIFICATION_EXTENSION_UNLOADED.

[battre, 2012/02/08 12:49:54]

Done.

 }
 
 void ExtensionService::UpdateExtensionBlacklist(
   const std::vector<std::string>& blacklist) {
   // Use this set to indicate if an extension in the blacklist has been used.
   std::set<std::string> blacklist_set;
   for (unsigned int i = 0; i < blacklist.size(); ++i) {
     if (Extension::IdIsValid(blacklist[i])) {
       blacklist_set.insert(blacklist[i]);
     }
@@ skipping 1510 matching lines @@
   //
   // To coexist with certain unit tests that don't have an IO thread message
   // loop available at ExtensionService shutdown, we lazy-initialize this
   // object so that those cases neither create nor destroy a SocketController.
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (!socket_controller_) {
     socket_controller_ = new extensions::SocketController();
   }
   return socket_controller_;
 }
+
+extensions::RulesRegistryService* ExtensionService::GetRulesRegistryService() {
+  if (!rules_registry_service_.get())
+    rules_registry_service_.reset(new extensions::RulesRegistryService());
+  return rules_registry_service_.get();
+}