Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: dbus/message_unittest.cc

Issue 9315006: Adding support for sending/receiving proto bufs to dbus library. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Resolved most of outstanding issues Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« dbus/dbus.gyp ('K') | « dbus/message.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "dbus/message.h" 5 #include "dbus/message.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "dbus/test_proto.pb.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 // Test that a byte can be properly written and read. We only have this 13 // Test that a byte can be properly written and read. We only have this
13 // test for byte, as repeating this for other basic types is too redundant. 14 // test for byte, as repeating this for other basic types is too redundant.
14 TEST(MessageTest, AppendAndPopByte) { 15 TEST(MessageTest, AppendAndPopByte) {
15 scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty()); 16 scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
16 dbus::MessageWriter writer(message.get()); 17 dbus::MessageWriter writer(message.get());
17 writer.AppendByte(123); // The input is 123. 18 writer.AppendByte(123); // The input is 123.
18 19
19 dbus::MessageReader reader(message.get()); 20 dbus::MessageReader reader(message.get());
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 dbus::MessageReader reader(message.get()); 220 dbus::MessageReader reader(message.get());
220 std::vector<std::string> output_object_paths; 221 std::vector<std::string> output_object_paths;
221 ASSERT_TRUE(reader.PopArrayOfObjectPaths(&output_object_paths)); 222 ASSERT_TRUE(reader.PopArrayOfObjectPaths(&output_object_paths));
222 ASSERT_FALSE(reader.HasMoreData()); 223 ASSERT_FALSE(reader.HasMoreData());
223 ASSERT_EQ(3U, output_object_paths.size()); 224 ASSERT_EQ(3U, output_object_paths.size());
224 EXPECT_EQ("/object/path/1", output_object_paths[0]); 225 EXPECT_EQ("/object/path/1", output_object_paths[0]);
225 EXPECT_EQ("/object/path/2", output_object_paths[1]); 226 EXPECT_EQ("/object/path/2", output_object_paths[1]);
226 EXPECT_EQ("/object/path/3", output_object_paths[2]); 227 EXPECT_EQ("/object/path/3", output_object_paths[2]);
227 } 228 }
228 229
230 TEST(MessageTest, ProtoBuf) {
231 scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
232 dbus::MessageWriter writer(message.get());
233 TestProto send_message;
234 send_message.set_text("testing");
satorux1 2012/02/01 19:14:57 To make test a little more interesting, could you
rharrison 2012/02/01 21:33:21 Done.
235 writer.AppendProtoAsArrayOfBytes(send_message);
236
237 dbus::MessageReader reader(message.get());
238 TestProto receive_message;
239 ASSERT_TRUE(reader.PopArrayOfBytesAsProto(&receive_message));
240 EXPECT_EQ(receive_message.text(), send_message.text());
satorux1 2012/02/01 19:14:57 Rather than comparing a field, it'be better to com
rharrison 2012/02/01 21:33:21 This is not available in MessageLite objects.
241 }
242
243
229 // Test that an array can be properly written and read. We only have this 244 // Test that an array can be properly written and read. We only have this
230 // test for array, as repeating this for other container types is too 245 // test for array, as repeating this for other container types is too
231 // redundant. 246 // redundant.
232 TEST(MessageTest, OpenArrayAndPopArray) { 247 TEST(MessageTest, OpenArrayAndPopArray) {
233 scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty()); 248 scoped_ptr<dbus::Response> message(dbus::Response::CreateEmpty());
234 dbus::MessageWriter writer(message.get()); 249 dbus::MessageWriter writer(message.get());
235 dbus::MessageWriter array_writer(message.get()); 250 dbus::MessageWriter array_writer(message.get());
236 writer.OpenArray("s", &array_writer); // Open an array of strings. 251 writer.OpenArray("s", &array_writer); // Open an array of strings.
237 array_writer.AppendString("foo"); 252 array_writer.AppendString("foo");
238 array_writer.AppendString("bar"); 253 array_writer.AppendString("bar");
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 530
516 EXPECT_EQ("org.chromium.destination", message->GetDestination()); 531 EXPECT_EQ("org.chromium.destination", message->GetDestination());
517 EXPECT_EQ("/org/chromium/path", message->GetPath()); 532 EXPECT_EQ("/org/chromium/path", message->GetPath());
518 EXPECT_EQ("org.chromium.interface", message->GetInterface()); 533 EXPECT_EQ("org.chromium.interface", message->GetInterface());
519 EXPECT_EQ("member", message->GetMember()); 534 EXPECT_EQ("member", message->GetMember());
520 EXPECT_EQ("org.chromium.error", message->GetErrorName()); 535 EXPECT_EQ("org.chromium.error", message->GetErrorName());
521 EXPECT_EQ(":1.2", message->GetSender()); 536 EXPECT_EQ(":1.2", message->GetSender());
522 EXPECT_EQ(123U, message->GetSerial()); 537 EXPECT_EQ(123U, message->GetSerial());
523 EXPECT_EQ(456U, message->GetReplySerial()); 538 EXPECT_EQ(456U, message->GetReplySerial());
524 } 539 }
OLDNEW
« dbus/dbus.gyp ('K') | « dbus/message.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698