Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5252)

Unified Diff: base/process_posix.cc

Issue 93147: POSIX: don't spawn zombies. (Closed)
Patch Set: ... Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/process_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_posix.cc
diff --git a/base/process_posix.cc b/base/process_posix.cc
index ff8cf92c52e79ebf1534e85b77b9f4ad4a4e1df8..c9a7dfcea0a5fa174a74cdc20906d90be442433a 100644
--- a/base/process_posix.cc
+++ b/base/process_posix.cc
@@ -18,8 +18,9 @@ void Process::Terminate(int result_code) {
// result_code isn't supportable.
if (!process_)
return;
- // Wait so we clean up the zombie
- KillProcess(process_, result_code, true);
+ // We don't wait here. It's the responsibility of other code to reap the
+ // child.
+ KillProcess(process_, result_code, false);
}
bool Process::IsProcessBackgrounded() const {
« no previous file with comments | « no previous file | base/process_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698