Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host.cc

Issue 9314037: Save As for content retrieved via POST works in most circumstances. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test page Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host.cc b/content/browser/renderer_host/resource_dispatcher_host.cc
index f39d36465d68a243d1284793f3302fe30ab78758..0c932cbc9a5c8a95e57115ea13b2edaba42c2457 100644
--- a/content/browser/renderer_host/resource_dispatcher_host.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host.cc
@@ -893,7 +893,10 @@ net::Error ResourceDispatcherHost::BeginDownload(
request->set_context(request_context);
int extra_load_flags = net::LOAD_IS_DOWNLOAD;
if (prefer_cache) {
- extra_load_flags |= net::LOAD_PREFERRING_CACHE;
+ if (request->get_upload() != NULL)
Randy Smith (Not in Mondays) 2012/02/02 19:46:10 I think I'd like a comment here. The form of the
cbentzel 2012/02/03 15:54:47 I cover this with a comment in BeginDownload in do
Randy Smith (Not in Mondays) 2012/02/03 19:43:06 I'm afraid so. Code's better when it can be under
cbentzel 2012/02/03 20:29:31 Patch Set #9 adds a comment here.
+ extra_load_flags |= net::LOAD_ONLY_FROM_CACHE;
+ else
+ extra_load_flags |= net::LOAD_PREFERRING_CACHE;
} else {
extra_load_flags |= net::LOAD_DISABLE_CACHE;
}

Powered by Google App Engine
This is Rietveld 408576698