Issue 9314020: Added CommandBuffer::GetLastError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9314020: Added CommandBuffer::GetLastError. (Closed)

Created:
8 years, 10 months ago by apatrick_chromium

Modified:
8 years, 10 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Added CommandBuffer::GetLastError. This is equivalent to GetLastState().error. It saves copying 6 ints. This is temporary until skia does not invoke MakeCurrent for every GL call. BUG==112187 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120022

Patch Set 1 #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
M	content/renderer/gpu/command_buffer_proxy.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/renderer/gpu/command_buffer_proxy.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/cmd_buffer_common.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/command_buffer.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/9314020/1

8 years, 10 months ago (2012-02-01 01:13:21 UTC) #3

Tom Hudson

8 years, 10 months ago (2012-02-01 14:52:24 UTC) #5

So this was the most-minimal changes of those we discussed in
http://code.google.com/p/chromium/issues/detail?id=112187, but I don't
understand why

(1) it's marked as temporary?
(2) we're still returning the State by value instead of by (const) reference?

Expand Messages | Collapse Messages