Issue 93139: Remove wget.exe and use a small javascript instead. Had issues with some AV.....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93139: Remove wget.exe and use a small javascript instead. Had issues with some AV..... (Closed)

Created:
11 years, 8 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
SkyLined

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Remove wget.exe and use a small javascript instead. Had issues with some AV... Actually, the get_file.js code was written by B.J. I have no merit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14457

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+115 lines, -1 line)			Patch
A	bootstrap/win/get_file.js	View	1 chunk	+114 lines, -0 lines	0 comments	Download
D	bootstrap/win/wget.exe	View	Binary file		0 comments	Download
M	bootstrap/win/win_tools.bat	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

SkyLined

11 years, 8 months ago (2009-04-24 19:59:46 UTC) #2

LGTM with one small addition.

http://codereview.chromium.org/93139/diff/1/2
File bootstrap/win/win_tools.bat (right):

http://codereview.chromium.org/93139/diff/1/2#newcode27
Line 27: cscript //nologo "%~dp0get_file.js"
%WIN_TOOLS_ROOT_URL%/third_party/svn_win_client.7z "%~dp0svn.7z"
I'd insert "/e:jscript" here too - to make sure cscript uses the right scripting
engine.

Expand Messages | Collapse Messages