Allow users to kill tasks by keystroke 'E'.

Allow users to kill tasks by keystroke 'E'.

BUG=7229

[tony, 2009-04-24 21:00:14]

I don't think Peterson works on chrome anymore.

The views::Button class has a method called SetAccessibleKeyboardShortcut. 
Maybe you should use that instead?  Having (E) on a button looks funny (it's not
a menu).

[hamaji, 2009-04-24 21:27:57]

Thanks for the review and notice on the reviewer!

On 2009/04/24 21:00:14, tony wrote:
> I don't think Peterson works on chrome anymore.
> 
> The views::Button class has a method called SetAccessibleKeyboardShortcut. 
> Maybe you should use that instead?  Having (E) on a button looks funny (it's
not
> a menu).

I changed the code to use SetAccessibleKeyboardShortcut. I added this (E) just
because Windows XP's task manager has the same string. Ah, it seems that vista
doesn't have this... I also added a check in KillSelectedProcesses() not to
allow users to kill the main process by touching 'e' unintentionally.

Thanks,

[tony, 2009-04-24 21:46:44]

I'm sorry.  I think I'm wrong about SetAccessibleKeyboardShortcut.  I think
instead you should try adding an accelerator for the button.  That way you don't
have to handle the keydown event yourself (the accelerator system will do it
automatically).

I also think it's intentional that you can kill the main browser process.

Adding jay since he wrote both the accelerator code and the task manager.

[hamaji, 2009-04-24 21:55:30]

On 2009/04/24 21:46:44, tony wrote:
> I'm sorry.  I think I'm wrong about SetAccessibleKeyboardShortcut.  I think
> instead you should try adding an accelerator for the button.  That way you
don't
> have to handle the keydown event yourself (the accelerator system will do it
> automatically).

If I understand SetAccessibleKeyboardShortcut correctly, this supports people
whose eye isn't so good? I thought setting this will break nothing and is
better.

> 
> I also think it's intentional that you can kill the main browser process.

When the main browser is selected in the task manager, the "End Process" button
is disabled. So, I think the designer of task manager considered that killing
the main browser by task manager should not be allowed.

> 
> Adding jay since he wrote both the accelerator code and the task manager.

[petersont, 2009-04-24 22:58:59]

> I don't think Peterson works on chrome anymore.

That's true, I don't, but when I did, I edited this file at some point.  From
reading this thread, it seems there's more to this keyboard shortcut than meets
the eye, so I'm going to leave it in chrome team's capable hands.
 
> The views::Button class has a method called SetAccessibleKeyboardShortcut. 
> Maybe you should use that instead?  Having (E) on a button looks funny (it's
not
> a menu).

[jcampan, 2009-04-27 20:53:38]

LGTM