Issue 93121: Fix bugs 145 and 323, preemption and apply on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93121: Fix bugs 145 and 323, preemption and apply on ARM. (Closed)

Created:
11 years, 8 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix bugs 145 and 323, preemption and apply on ARM. Committed: http://code.google.com/p/v8/source/detail?r=1794

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -27 lines)			Patch
M	src/arm/assembler-arm.h	View	1	1 chunk	+17 lines, -17 lines	0 comments	Download
M	src/arm/builtins-arm.cc	View	1	1 chunk	+24 lines, -4 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/cctest/cctest.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-hashmap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-list.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

11 years, 8 months ago (2009-04-27 05:24:39 UTC) #2

LGTM.

http://codereview.chromium.org/93121/diff/1/5
File src/arm/builtins-arm.cc (right):

http://codereview.chromium.org/93121/diff/1/5#newcode434
Line 434: __ mov(ip, Operand(Smi::FromInt(0)));
Maybe use r0 instead of ip here? Some of the complex ARM assembler
"instructions" (not these though) manipulate ip behind the scenes.

http://codereview.chromium.org/93121/diff/1/6
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/93121/diff/1/6#newcode4601
Line 4601: __ mov(ip, Operand(Smi::FromInt(0)));
ip -> r0?

Expand Messages | Collapse Messages