Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 9312001: Add bluetooth callbacks for fetching paired devices and stopping device discovery. (Closed)

Created:
8 years, 10 months ago by kevers
Modified:
8 years, 10 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), keybuk
Visibility:
Public.

Description

Add bluetooth callbacks for fetching paired devices and stopping device discovery. BUG=chromium:102139 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119968

Patch Set 1 #

Total comments: 2

Patch Set 2 : Prune log messages. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M chrome/browser/resources/options2/advanced_options.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_add_device_overlay.js View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.h View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc View 1 3 chunks +32 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevers
Hi James, Can you please have a look at this CL.
8 years, 10 months ago (2012-01-31 17:55:33 UTC) #1
James Hawkins
lgtm http://codereview.chromium.org/9312001/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc File chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc (right): http://codereview.chromium.org/9312001/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc#newcode234 chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc:234: DVLOG(2) << "Stop searching for Bluetooth devices"; Did ...
8 years, 10 months ago (2012-01-31 18:14:27 UTC) #2
kevers
http://codereview.chromium.org/9312001/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc File chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc (right): http://codereview.chromium.org/9312001/diff/1/chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc#newcode234 chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler2.cc:234: DVLOG(2) << "Stop searching for Bluetooth devices"; On 2012/01/31 ...
8 years, 10 months ago (2012-01-31 18:20:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/9312001/6001
8 years, 10 months ago (2012-01-31 20:13:05 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 22:00:56 UTC) #5
Change committed as 119968

Powered by Google App Engine
This is Rietveld 408576698