Issue 93120: Changed the ASSERT's in the cctest's to CHECK's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93120: Changed the ASSERT's in the cctest's to CHECK's (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Changed the ASSERT's in the cctest's to CHECK's. There are no ASSERTS left in the cctest's. Committed: http://code.google.com/p/v8/source/detail?r=1793

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -32 lines)			Patch
M	test/cctest/test-api.cc	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	7 chunks	+19 lines, -17 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/cctest/test-hashmap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-list.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-strings.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Christian Plesner Hansen

11 years, 8 months ago (2009-04-24 12:53:51 UTC) #2

Lgtm.

We might consider undefining the ASSERTs in cctest.h so people get an error if
they accidentally use them.