Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 93118: Removed the debug message thread (Closed)

Created:
11 years, 8 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
yurys
CC:
v8-dev
Visibility:
Public.

Description

Removed the debug message thread. The debug message thread was introduced to make it possible to have the message handler callback be called from a different thread than the thread running V8 where the debug event occoured, but it never had any practical use, and prevents providing information to the message handler which is only available from the V8 thread. In the future any thread decoupling will have do be done by the embedder. This also removes the queue used for outbound messages. Renamed the class Message to CommandMessage as it is only used for debugger commands from the client. Related message queue classes has also been renamed. Committed: http://code.google.com/p/v8/source/detail?r=1788

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -200 lines) Patch
M include/v8-debug.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M src/api.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/debug.h View 1 4 chunks +29 lines, -62 lines 0 comments Download
M src/debug.cc View 1 12 chunks +48 lines, -116 lines 0 comments Download
M src/debug-agent.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-debug.cc View 1 3 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 8 months ago (2009-04-24 10:08:06 UTC) #1
yurys
11 years, 8 months ago (2009-04-24 11:15:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698