Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 93116: Chrome side of using WebPluginListBuilder.... (Closed)

Created:
11 years, 8 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
dglazkov
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Chrome side of using WebPluginListBuilder. I also broke glue/webplugininfo.h out of glue/webplugin.h as part of this change. Eventually, glue/webplugin.h will go away and be moved into the WebKit API, but the structures left in glue/webplugininfo.h need to remain since they are used extensively throughout Chrome. BUG=10922 R=dglazkov Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=14438

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -217 lines) Patch
M chrome/browser/metrics/metrics_log.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_process_host.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_service.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/build/WebKit/WebKit.vcproj View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M webkit/glue/chromium_bridge_impl.cc View 1 2 3 1 chunk +0 lines, -37 lines 0 comments Download
M webkit/glue/glue.vcproj View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/glue_util.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_list.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/simple_webmimeregistry_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 3 chunks +35 lines, -1 line 0 comments Download
M webkit/glue/webplugin.h View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
A + webkit/glue/webplugininfo.h View 3 chunks +4 lines, -138 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/webkit.gyp View 1 2 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
11 years, 8 months ago (2009-04-24 07:46:46 UTC) #1
dglazkov
Missing glue.vcproj changes.
11 years, 8 months ago (2009-04-24 16:04:33 UTC) #2
darin (slow to review)
Please take another look. I had to remove it in order to pass the try ...
11 years, 8 months ago (2009-04-24 16:43:22 UTC) #3
dglazkov
11 years, 8 months ago (2009-04-24 16:49:59 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698