Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: presubmit.py

Issue 93108: Fix gclient on posix platforms.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gclient ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit.py
===================================================================
--- presubmit.py (revision 14399)
+++ presubmit.py (working copy)
@@ -601,8 +601,7 @@
committing,
verbose,
output_stream,
- input_stream,
- default_presubmit):
+ input_stream):
"""Runs all presubmit checks that apply to the files in the change.
This finds all PRESUBMIT.py files in directories enclosing the files in the
@@ -618,7 +617,6 @@
verbose: Prints debug info.
output_stream: A stream to write output from presubmit tests to.
input_stream: A stream to read input from the user.
- default_presubmit: A default presubmit script to execute in any case.
Return:
True if execution can continue, False if not.
@@ -628,10 +626,6 @@
print "Warning, no presubmit.py found."
results = []
executer = PresubmitExecuter(change_info, committing)
- if default_presubmit:
- if verbose:
- print "Running default presubmit script"
- results += executer.ExecPresubmitScript(default_presubmit, 'PRESUBMIT.py')
for filename in presubmit_files:
if verbose:
print "Running %s" % filename
@@ -703,12 +697,11 @@
files = ParseFiles(args, options.recursive)
if options.verbose:
print "Found %d files." % len(files)
- return not DoPresubmitChecks(gcl.ChangeInfo(name='temp', files=files),
- options.commit,
- options.verbose,
- sys.stdout,
- sys.stdin,
- default_presubmit=None)
+ return DoPresubmitChecks(gcl.ChangeInfo(name='temp', files=files),
+ options.commit,
+ options.verbose,
+ sys.stdout,
+ sys.stdin)
if __name__ == '__main__':
« no previous file with comments | « gclient ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698