Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: src/ic-inl.h

Issue 9310117: Implement KeyedStoreICs to grow arrays on out-of-bound stores. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: nits Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 76
77 77
78 void IC::SetTargetAtAddress(Address address, Code* target) { 78 void IC::SetTargetAtAddress(Address address, Code* target) {
79 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub()); 79 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub());
80 #ifdef DEBUG 80 #ifdef DEBUG
81 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 81 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
82 // ICs as strict mode. The strict-ness of the IC must be preserved. 82 // ICs as strict mode. The strict-ness of the IC must be preserved.
83 Code* old_target = GetTargetAtAddress(address); 83 Code* old_target = GetTargetAtAddress(address);
84 if (old_target->kind() == Code::STORE_IC || 84 if (old_target->kind() == Code::STORE_IC ||
85 old_target->kind() == Code::KEYED_STORE_IC) { 85 old_target->kind() == Code::KEYED_STORE_IC) {
86 ASSERT(old_target->extra_ic_state() == target->extra_ic_state()); 86 ASSERT(Code::GetStrictMode(old_target->extra_ic_state()) ==
87 Code::GetStrictMode(target->extra_ic_state()));
87 } 88 }
88 #endif 89 #endif
89 Assembler::set_target_address_at(address, target->instruction_start()); 90 Assembler::set_target_address_at(address, target->instruction_start());
90 target->GetHeap()->incremental_marking()->RecordCodeTargetPatch(address, 91 target->GetHeap()->incremental_marking()->RecordCodeTargetPatch(address,
91 target); 92 target);
92 } 93 }
93 94
94 95
95 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 96 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
96 JSObject* holder) { 97 JSObject* holder) {
(...skipping 26 matching lines...) Expand all
123 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) { 124 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) {
124 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype()); 125 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype());
125 ASSERT(map_owner->IsJSObject()); 126 ASSERT(map_owner->IsJSObject());
126 return JSObject::cast(map_owner); 127 return JSObject::cast(map_owner);
127 } 128 }
128 129
129 130
130 } } // namespace v8::internal 131 } } // namespace v8::internal
131 132
132 #endif // V8_IC_INL_H_ 133 #endif // V8_IC_INL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698