Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4043)

Unified Diff: chrome/browser/web_applications/web_app.cc

Issue 9310079: Moved app shortcut code out of ExtensionService. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fixed stupid virtual ommission Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_applications/web_app.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app.cc
diff --git a/chrome/browser/web_applications/web_app.cc b/chrome/browser/web_applications/web_app.cc
index 4f8f5df44cf42745dad76e622fb3c495681591c5..7b43c567f3040b0d622921450275c8dad9930696 100644
--- a/chrome/browser/web_applications/web_app.cc
+++ b/chrome/browser/web_applications/web_app.cc
@@ -36,10 +36,6 @@ using content::BrowserThread;
namespace {
-// Allow tests to disable shortcut creation, to prevent developers desktops
-// becoming overrun with shortcuts.
-bool disable_shortcut_creation_for_tests = false;
-
#if defined(OS_WIN)
const FilePath::CharType kIconChecksumFileExt[] = FILE_PATH_LITERAL(".ico.md5");
@@ -158,9 +154,6 @@ void CreateShortcutTask(const FilePath& web_app_path,
const ShellIntegration::ShortcutInfo& shortcut_info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- if (disable_shortcut_creation_for_tests)
- return;
-
#if defined(OS_POSIX) && !defined(OS_MACOSX)
scoped_ptr<base::Environment> env(base::Environment::Create());
@@ -430,10 +423,6 @@ void CreateShortcut(
shortcut_info));
}
-void SetDisableShortcutCreationForTests(bool disable) {
- disable_shortcut_creation_for_tests = disable;
-}
-
bool IsValidUrl(const GURL& url) {
static const char* const kValidUrlSchemes[] = {
chrome::kFileScheme,
« no previous file with comments | « chrome/browser/web_applications/web_app.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698