Moved app shortcut code out of ExtensionService.

chrome/browser/extensions/app_shortcut_manager.cc

Index: chrome/browser/extensions/app_shortcut_manager.cc
diff --git a/chrome/browser/extensions/app_shortcut_manager.cc b/chrome/browser/extensions/app_shortcut_manager.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7813b79af2f7da79acab21019bafe7d6971f3387
--- /dev/null
+++ b/chrome/browser/extensions/app_shortcut_manager.cc
@@ -0,0 +1,85 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/app_shortcut_manager.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/web_applications/web_app.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/extension_resource.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_source.h"
+#include "grit/theme_resources.h"
+
+AppShortcutManager::AppShortcutManager(Profile* profile)
+    : profile_(profile),
+      disable_shortcut_creation_(false),
+      tracker_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {
+  registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,
+                 content::Source<Profile>(profile_));
+}
+
+void AppShortcutManager::OnImageLoaded(SkBitmap *image,
+                                       const ExtensionResource &resource,
+                                       int index) {
+  // If the image failed to load (e.g. if the resource being loaded was empty)
+  // use the standard application icon.
+  if (!image || image->isNull())
+    image = ExtensionIconSource::LoadImageByResourceId(IDR_APP_DEFAULT_ICON);
+
+  shortcut_info_.favicon = *image;
+  web_app::CreateShortcut(profile_->GetPath(), shortcut_info_);
+}
+
+void AppShortcutManager::Observe(int type,
+                                 const content::NotificationSource& source,
+                                 const content::NotificationDetails& details) {
+  DCHECK(type == chrome::NOTIFICATION_EXTENSION_INSTALLED);

[Mihai Parparita -not on Chrome, 2012/02/06 22:35:53]

We may want this for when an extension is updated too (it's possible for
extensions to change types, and Docs is looking to change their current hosted
app to a platform app).

[benwells, 2012/02/07 06:57:01]

That makes sense. We'd only want to create the shortcuts when the extension
first becomes a platform app. Maybe I can look at this in a separate change? A
similar thing we need to do is remove shortcuts at uninstall.

+  const Extension* extension = content::Details<const Extension>(details).ptr();
+  if (!disable_shortcut_creation_ && extension->is_platform_app())
+    InstallApplicationShortcuts(extension);
+}
+
+void AppShortcutManager::InstallApplicationShortcuts(
+    const Extension* extension) {
+#if !defined(OS_MACOSX)
+  const int kAppIconSize = 32;
+
+  shortcut_info_.extension_id = extension->id();
+  shortcut_info_.url = GURL(extension->launch_web_url());
+  shortcut_info_.title = UTF8ToUTF16(extension->name());
+  shortcut_info_.description = UTF8ToUTF16(extension->description());
+  shortcut_info_.create_in_applications_menu = true;
+  shortcut_info_.create_in_quick_launch_bar = true;
+  shortcut_info_.create_on_desktop = true;
+
+  // The icon will be resized to |max_size|.
+  const gfx::Size max_size(kAppIconSize, kAppIconSize);
+
+  // Look for an icon. If there is no icon at the ideal size, we will resize
+  // whatever we can get. Making a large icon smaller is prefered to making a
+  // small icon larger, so look for a larger icon first:
+  ExtensionResource icon_resource = extension->GetIconResource(
+      kAppIconSize,
+      ExtensionIconSet::MATCH_BIGGER);
+
+  // If no icon exists that is the desired size or larger, get the
+  // largest icon available:
+  if (icon_resource.empty()) {
+    icon_resource = extension->GetIconResource(
+        kAppIconSize,
+        ExtensionIconSet::MATCH_SMALLER);
+  }
+
+  // icon_resource may still be empty at this point, in which case LoadImage
+  // which call the OnImageLoaded callback with a NULL image and exit
+  // immediately.
+  tracker_.LoadImage(extension,
+                     icon_resource,
+                     max_size,
+                     ImageLoadingTracker::DONT_CACHE);
+#endif
+}