Moved app shortcut code out of ExtensionService.

chrome/browser/extensions/app_shortcut_manager.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_APP_SHORTCUT_MANAGER_H_
+#define CHROME_BROWSER_EXTENSIONS_APP_SHORTCUT_MANAGER_H_
+#pragma once
+
+#include "chrome/browser/extensions/image_loading_tracker.h"
+#include "chrome/browser/shell_integration.h"
+#include "chrome/common/extensions/extension.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+
+class Profile;
+
+// This class manages the installation of shortcuts for platform apps.
+class AppShortcutManager : public ImageLoadingTracker::Observer,
+                           public content::NotificationObserver {
+ public:
+  explicit AppShortcutManager(Profile* profile);
+
+  // Implement ImageLoadingTracker::Observer. |tracker_| is used to
+  // load the application's icon, which is done when we start creating an
+  // application's shortcuts. This method receives the icon, and completes
+  // the process of installing the shortcuts.
+  virtual void OnImageLoaded(SkBitmap* image,
+                             const ExtensionResource& resource,
+                             int index) OVERRIDE;
+
+  // content::NotificationObserver
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  void set_disable_shortcut_creation(bool val) {

[Mihai Parparita -not on Chrome, 2012/02/06 22:35:53]

This should have a for_testing suffix so that it's not callable from non-test
code.

[benwells, 2012/02/07 06:57:01]

Neat, I didn't know that suffix did that!

Done for the renamed static function.

+    disable_shortcut_creation_ = val;
+  }
+ private:
+  // Install the shortcuts for an application.
+  void InstallApplicationShortcuts(const Extension* extension);
+
+  content::NotificationRegistrar registrar_;
+  Profile* profile_;
+
+  // Used to disable shortcut creation in tests.
+  bool disable_shortcut_creation_;
+
+  // Fields used when installing application shortcuts.
+  ShellIntegration::ShortcutInfo shortcut_info_;
+  ImageLoadingTracker tracker_;
+
+  DISALLOW_COPY_AND_ASSIGN(AppShortcutManager);
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_APP_SHORTCUT_MANAGER_H_