Ensure the previously active browser window gets the focus after a browser window is closed on OSX.

chrome/browser/ui/cocoa/browser_window_controller.mm

Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 627ec8ac53bad035de45c99ec816c7c2af1a6193..07b1cd74f11ef30858b8bcf859b981296d0fb6b4 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -545,6 +545,10 @@ enum {
   // have to save the window position before we call orderOut:.
   [self saveWindowPositionIfNeeded];
 
+  // Ensure focus goes to previous active browser window when this
+  // window is ordered out.
+  [BrowserWindowUtils selectPreviousActiveBrowserWindow:browser_.get()];

[pink (ping after 24hrs), 2012/02/03 14:24:55]

What is the behavior of other applications on Mac with regard to panels and
window focus? Why are we usurping what the OS wants to do?

[jennb, 2012/02/03 18:12:06]

Mac's window ordering selects from among the application's windows so the panel
browser windows do not affect other applications.

[pink (ping after 24hrs), 2012/02/03 18:42:23]

I meant what do other applications do in this similar circumstance?

[jennb, 2012/02/03 19:20:30]

Most applications don't modify window levels. When they do, they want to get a
high priority window so it naturally should take precedence in window ordering.
We're using the higher priority without wanting to take precedence, making us a
unique case.

+
   if (!browser_->tabstrip_model()->empty()) {
     // Tab strip isn't empty.  Hide the frame (so it appears to have closed
     // immediately) and close all the tabs, allowing the renderers to shut