Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/ui/cocoa/web_intent_picker_cocoa.h

Issue 9310074: Switch to using WebIntentPickerModel, and bring picker closer to mocks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed review issues Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
diff --git a/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h b/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
index b0deb420619a1bacb82aaba77b2da1b58f9da706..0820bf27f61e568e617e578f8c5b150225967656 100644
--- a/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
+++ b/chrome/browser/ui/cocoa/web_intent_picker_cocoa.h
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
#include "chrome/browser/ui/intents/web_intent_picker.h"
#include "chrome/browser/ui/intents/web_intent_picker_model.h"
#include "chrome/browser/ui/intents/web_intent_picker_model_observer.h"
@@ -55,12 +56,21 @@ class WebIntentPickerCocoa : public WebIntentPicker,
WebIntentBubbleController* controller_; // Weak reference.
+ // Factory for weak ptrs, used for delayed callbacks.
+ base::WeakPtrFactory<WebIntentPickerCocoa> weak_ptr_factory_;
+
// Tab contents wrapper to hold intent page if inline disposition is used.
scoped_ptr<TabContentsWrapper> inline_disposition_tab_contents_;
// Delegate for inline disposition tab contents.
scoped_ptr<InlineHtmlContentDelegate> inline_disposition_delegate_;
+ // Post a delayed task to do layout, if it isn't already pending.
+ void PerformDelayedLayout();
+
+ // Re-layout the intent picker.
+ void PerformLayout();
+
// Default constructor, for testing only.
WebIntentPickerCocoa();

Powered by Google App Engine
This is Rietveld 408576698