Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: media/base/filters.h

Issue 9310028: Update AudioRenderer, VideoRenderer, and AudioDecoder Initialize() methods to use PipelineStatusCB. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix AudioRendererImplTest Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/composite_filter_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/filters.h
diff --git a/media/base/filters.h b/media/base/filters.h
index cf8bcea82ca1eed17ccfe470ab357756856c5659..49927237ad4e6072e17fa5121f60cbacbfe0bafd 100644
--- a/media/base/filters.h
+++ b/media/base/filters.h
@@ -174,9 +174,8 @@ class MEDIA_EXPORT AudioDecoder : public Filter {
// Initialize a AudioDecoder with the given DemuxerStream, executing the
// callback upon completion.
// stats_callback is used to update global pipeline statistics.
- //
- // TODO(scherkus): switch to PipelineStatus callback.
- virtual void Initialize(DemuxerStream* stream, const base::Closure& callback,
+ virtual void Initialize(DemuxerStream* stream,
+ const PipelineStatusCB& callback,
const StatisticsCallback& stats_callback) = 0;
// Request samples to be decoded and returned via the provided callback.
@@ -207,7 +206,8 @@ class MEDIA_EXPORT VideoRenderer : public Filter {
public:
// Initialize a VideoRenderer with the given VideoDecoder, executing the
// callback upon completion.
- virtual void Initialize(VideoDecoder* decoder, const base::Closure& callback,
+ virtual void Initialize(VideoDecoder* decoder,
+ const PipelineStatusCB& callback,
const StatisticsCallback& stats_callback) = 0;
// Returns true if this filter has received and processed an end-of-stream
@@ -225,7 +225,7 @@ class MEDIA_EXPORT AudioRenderer : public Filter {
// to resume playback. Pause(), Seek(), or Stop() cancels the underflow
// condition.
virtual void Initialize(AudioDecoder* decoder,
- const base::Closure& init_callback,
+ const PipelineStatusCB& init_callback,
const base::Closure& underflow_callback) = 0;
// Returns true if this filter has received and processed an end-of-stream
« no previous file with comments | « media/base/composite_filter_unittest.cc ('k') | media/base/mock_filters.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698