Move more extensions hard coded error messages to .grd file.

Move more extensions hard coded error messages to .grd file.

BUG=23086
TEST=compiles

Patch from Thiago Farina <thiago.farina@gmail.com>;

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43691

[tfarina (gmail-do not use), 2010-03-14 18:18:21]

Hi Aaron, could you review this to me?

One thing is that I left the description of the messages in blank. I don't know
if you can land it without these descriptions.

There are some messages that I copied from the extension_constants.cc to the
.grd file, but I'm 100% if it was necessary.

-Thiago

[tfarina (gmail-do not use), 2010-03-18 11:11:48]

Ping.

[tfarina (gmail-do not use), 2010-03-24 20:05:54]

Ping2

[Finnur, 2010-03-31 19:35:14]

Sorry to keep you waiting. Aaron has been a little swamped lately. He asked me
to review this changelist for him.

Can you sync again and upload a new patch?

http://codereview.chromium.org/931001/diff/12001/13001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/931001/diff/12001/13001#newcode3320
chrome/app/generated_resources.grd:3320: Could not load extension icon <ph
name="ICON">$1<ex>icon.png</ex></ph>.
The single quote should be retained around the parameter (it got lost in the
transfer). Same with one above and these below.

http://codereview.chromium.org/931001/diff/12001/13001#newcode3329
chrome/app/generated_resources.grd:3329: Could not load  <ph
name="PLUGIN_PATH">$1<ex>/path/to/file</ex></ph> for plugin.
extra space after 'load'.

http://codereview.chromium.org/931001/diff/12001/13002
File chrome/common/extensions/extension_file_util.cc (left):

http://codereview.chromium.org/931001/diff/12001/13002#oldcode113
chrome/common/extensions/extension_file_util.cc:113: *error =
extension_manifest_errors::kManifestUnreadable;
So, we now have these string in two locations, right? One is defined as
kManifestUnreadable and the other is the string in the grd. Shouldn't we
eliminate this const strings if we have them in the grd?

[tfarina (gmail-do not use), 2010-04-03 04:32:01]

On 2010/03/31 19:35:14, Finnur wrote:
> Sorry to keep you waiting. Aaron has been a little swamped lately. He asked me
> to review this changelist for him.
> 
> Can you sync again and upload a new patch?

Sure, I will do this today.

[tfarina (gmail-do not use), 2010-04-05 02:55:52]

http://codereview.chromium.org/931001/diff/12001/13001
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/931001/diff/12001/13001#newcode3320
chrome/app/generated_resources.grd:3320: Could not load extension icon <ph
name="ICON">$1<ex>icon.png</ex></ph>.
On 2010/03/31 19:35:14, Finnur wrote:
> The single quote should be retained around the parameter (it got lost in the
> transfer). Same with one above and these below.

Done.

http://codereview.chromium.org/931001/diff/12001/13001#newcode3329
chrome/app/generated_resources.grd:3329: Could not load  <ph
name="PLUGIN_PATH">$1<ex>/path/to/file</ex></ph> for plugin.
On 2010/03/31 19:35:14, Finnur wrote:
> extra space after 'load'.

Done.

http://codereview.chromium.org/931001/diff/12001/13002
File chrome/common/extensions/extension_file_util.cc (left):

http://codereview.chromium.org/931001/diff/12001/13002#oldcode113
chrome/common/extensions/extension_file_util.cc:113: *error =
extension_manifest_errors::kManifestUnreadable;
On 2010/03/31 19:35:14, Finnur wrote:
> So, we now have these string in two locations, right? One is defined as
> kManifestUnreadable and the other is the string in the grd. Shouldn't we
> eliminate this const strings if we have them in the grd?

Yes, we should eliminate these const strings. But I would like to do this as a
separate patch to not increase the size of this change. But if you want I will
do everything here.

[Finnur, 2010-04-05 06:51:57]

LGTM. 

> But I would like to do this as a
> separate patch 

OK, that's fine.