aura: Fix a couple of tooltip related bugs:

aura: Fix a couple of tooltip related bugs:
1. Position tooltips correctly when they are out of screen bounds
2. Hide tooltips when lockscreen is shown

BUG=112121, 110128
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120086

[Ben Goodger (Google), 2012-02-01 17:03:49]

LGTM.

You should write tests for the tooltip placement at some point.

Also, I haven't tested, but does the same bug that affects tooltips with the
lock screen also affect context menus? e.g. right click on something then press
Ctrl+Shift+L

[varunjain, 2012-02-01 17:18:31]

On 2012/02/01 17:03:49, Ben Goodger (Google) wrote:
> LGTM.
> 
> You should write tests for the tooltip placement at some point.
> 
> Also, I haven't tested, but does the same bug that affects tooltips with the
> lock screen also affect context menus? e.g. right click on something then
press
> Ctrl+Shift+L

According to a quick test, Ctrl+Shft+L does not trigger the lock screen when a
menu is on screen (The menu seems to be taking all keyboard events). Not sure if
thats the expected behavior.

[Ben Goodger (Google), 2012-02-01 17:19:24]

I think Peter/Oshima were working on a fix for that?

On Wed, Feb 1, 2012 at 9:18 AM, <varunjain@chromium.org> wrote:

> On 2012/02/01 17:03:49, Ben Goodger (Google) wrote:
>
>> LGTM.
>>
>
>  You should write tests for the tooltip placement at some point.
>>
>
>  Also, I haven't tested, but does the same bug that affects tooltips with
>> the
>> lock screen also affect context menus? e.g. right click on something then
>>
> press
>
>> Ctrl+Shift+L
>>
>
> According to a quick test, Ctrl+Shft+L does not trigger the lock screen
> when a
> menu is on screen (The menu seems to be taking all keyboard events). Not
> sure if
> thats the expected behavior.
>
>
https://chromiumcodereview.**appspot.com/9310008/<https://chromiumcodereview....
>

[Ben Goodger (Google), 2012-02-01 17:19:56]

On a device, what happens if you push the power button (briefly, just to
lock) while a menu is up? :-)

-Ben

On Wed, Feb 1, 2012 at 9:19 AM, Ben Goodger (Google) <ben@chromium.org>wrote:

> I think Peter/Oshima were working on a fix for that?
>
>
> On Wed, Feb 1, 2012 at 9:18 AM, <varunjain@chromium.org> wrote:
>
>> On 2012/02/01 17:03:49, Ben Goodger (Google) wrote:
>>
>>> LGTM.
>>>
>>
>>  You should write tests for the tooltip placement at some point.
>>>
>>
>>  Also, I haven't tested, but does the same bug that affects tooltips with
>>> the
>>> lock screen also affect context menus? e.g. right click on something then
>>>
>> press
>>
>>> Ctrl+Shift+L
>>>
>>
>> According to a quick test, Ctrl+Shft+L does not trigger the lock screen
>> when a
>> menu is on screen (The menu seems to be taking all keyboard events). Not
>> sure if
>> thats the expected behavior.
>>
>>
https://chromiumcodereview.**appspot.com/9310008/<https://chromiumcodereview....
>>
>
>

[varunjain, 2012-02-01 17:23:30]

On 2012/02/01 17:19:56, Ben Goodger (Google) wrote:
> On a device, what happens if you push the power button (briefly, just to
> lock) while a menu is up? :-)

menu disappears :)


> 
> -Ben
> 
> On Wed, Feb 1, 2012 at 9:19 AM, Ben Goodger (Google) <ben@chromium.org>wrote:
> 
> > I think Peter/Oshima were working on a fix for that?
> >
> >
> > On Wed, Feb 1, 2012 at 9:18 AM, <mailto:varunjain@chromium.org> wrote:
> >
> >> On 2012/02/01 17:03:49, Ben Goodger (Google) wrote:
> >>
> >>> LGTM.
> >>>
> >>
> >>  You should write tests for the tooltip placement at some point.
> >>>
> >>
> >>  Also, I haven't tested, but does the same bug that affects tooltips with
> >>> the
> >>> lock screen also affect context menus? e.g. right click on something then
> >>>
> >> press
> >>
> >>> Ctrl+Shift+L
> >>>
> >>
> >> According to a quick test, Ctrl+Shft+L does not trigger the lock screen
> >> when a
> >> menu is on screen (The menu seems to be taking all keyboard events). Not
> >> sure if
> >> thats the expected behavior.
> >>
> >>
>
https://chromiumcodereview.**appspot.com/9310008/%3Chttps://chromiumcoderevie...>
> >>
> >
> >

[Ben Goodger (Google), 2012-02-01 17:24:19]

Good enough!

On Wed, Feb 1, 2012 at 9:23 AM, <varunjain@chromium.org> wrote:

> On 2012/02/01 17:19:56, Ben Goodger (Google) wrote:
>
>> On a device, what happens if you push the power button (briefly, just to
>> lock) while a menu is up? :-)
>>
>
> menu disappears :)
>
>
>
>
>  -Ben
>>
>
>  On Wed, Feb 1, 2012 at 9:19 AM, Ben Goodger (Google) <ben@chromium.org
>> >wrote:
>>
>
>  > I think Peter/Oshima were working on a fix for that?
>> >
>> >
>> > On Wed, Feb 1, 2012 at 9:18 AM, <mailto:varunjain@chromium.org**>
>> wrote:
>> >
>> >> On 2012/02/01 17:03:49, Ben Goodger (Google) wrote:
>> >>
>> >>> LGTM.
>> >>>
>> >>
>> >>  You should write tests for the tooltip placement at some point.
>> >>>
>> >>
>> >>  Also, I haven't tested, but does the same bug that affects tooltips
>> with
>> >>> the
>> >>> lock screen also affect context menus? e.g. right click on something
>> then
>> >>>
>> >> press
>> >>
>> >>> Ctrl+Shift+L
>> >>>
>> >>
>> >> According to a quick test, Ctrl+Shft+L does not trigger the lock screen
>> >> when a
>> >> menu is on screen (The menu seems to be taking all keyboard events).
>> Not
>> >> sure if
>> >> thats the expected behavior.
>> >>
>> >>
>>
>
> https://chromiumcodereview.**a**ppspot.com/9310008/%3Chttps://**
>
chromiumcodereview.appspot.**com/9310008/<http://appspot.com/9310008/%3Chttps://chromiumcodereview.appspot.com/9310008/>
> >
>
>> >>
>> >
>> >
>>
>
>
>
>
https://chromiumcodereview.**appspot.com/9310008/<https://chromiumcodereview....
>

[commit-bot: I haz the power, 2012-02-01 17:24:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/9310008/1

[commit-bot: I haz the power, 2012-02-01 20:02:55]

Change committed as 120086