Implement canvas's globalCompositeOperation lighter properly....

Integrate change of Skia upstream.
This is a cherry-pick of the following change:

http://code.google.com/p/skia/source/detail?r=159

We introduce this change for the 'lighter' composite operation. We need kAdd_Mode, which is introduced in this change for the operation.

Patch by Shinichiro Hamaji.

BUG=1619

[reed_android.com, 2009-04-24 12:23:28]

I would prefer we add a new mode called Add, and then reference that from
webkit, rather than changing the current lighten implementation.

I will do that on skia/trunk

On 2009/04/23 23:00:36, hamaji wrote:
>

[hamaji, 2009-04-24 20:54:00]

On 2009/04/24 12:23:28, reed wrote:
> I would prefer we add a new mode called Add, and then reference that from
> webkit, rather than changing the current lighten implementation.
> 
> I will do that on skia/trunk

Mike, thanks for accepting this patch.

So, now I modified this patch so that this patch is now integration from Skia
upstream. Brett, could you check this patch?

The upstream change was

http://code.google.com/p/skia/source/detail?r=159

(please note that I didn't introduce all changes from this revision because
there were actually two changes in the change of the Skia upstream)

Thanks!


> 
> On 2009/04/23 23:00:36, hamaji wrote:
> >

[Dean McNamee, 2009-04-28 11:38:28]

This looks ok, but the description needs to be updated so it's clear this is
just a cherry-pick of a upstream Skia patch.

On 2009/04/24 20:54:00, hamaji wrote:
> On 2009/04/24 12:23:28, reed wrote:
> > I would prefer we add a new mode called Add, and then reference that from
> > webkit, rather than changing the current lighten implementation.
> > 
> > I will do that on skia/trunk
> 
> Mike, thanks for accepting this patch.
> 
> So, now I modified this patch so that this patch is now integration from Skia
> upstream. Brett, could you check this patch?
> 
> The upstream change was
> 
> http://code.google.com/p/skia/source/detail?r=159
> 
> (please note that I didn't introduce all changes from this revision because
> there were actually two changes in the change of the Skia upstream)
> 
> Thanks!
> 
> 
> > 
> > On 2009/04/23 23:00:36, hamaji wrote:
> > >

[hamaji, 2009-04-28 16:13:36]

Thanks for the review.

On 2009/04/28 11:38:28, Dean McNamee wrote:
> This looks ok, but the description needs to be updated so it's clear this is
> just a cherry-pick of a upstream Skia patch.

I see. I simplified the description.

> 
> On 2009/04/24 20:54:00, hamaji wrote:
> > On 2009/04/24 12:23:28, reed wrote:
> > > I would prefer we add a new mode called Add, and then reference that from
> > > webkit, rather than changing the current lighten implementation.
> > > 
> > > I will do that on skia/trunk
> > 
> > Mike, thanks for accepting this patch.
> > 
> > So, now I modified this patch so that this patch is now integration from
Skia
> > upstream. Brett, could you check this patch?
> > 
> > The upstream change was
> > 
> > http://code.google.com/p/skia/source/detail?r=159
> > 
> > (please note that I didn't introduce all changes from this revision because
> > there were actually two changes in the change of the Skia upstream)
> > 
> > Thanks!
> > 
> > 
> > > 
> > > On 2009/04/23 23:00:36, hamaji wrote:
> > > >

[hamaji, 2009-04-29 18:40:11]

Ping. If there are no more issues, could someone check this in? I don't have SVN
write permission yet.

Thanks,

On 2009/04/28 16:13:36, hamaji wrote:
> Thanks for the review.
> 
> On 2009/04/28 11:38:28, Dean McNamee wrote:
> > This looks ok, but the description needs to be updated so it's clear this is
> > just a cherry-pick of a upstream Skia patch.
> 
> I see. I simplified the description.
> 
> > 
> > On 2009/04/24 20:54:00, hamaji wrote:
> > > On 2009/04/24 12:23:28, reed wrote:
> > > > I would prefer we add a new mode called Add, and then reference that
from
> > > > webkit, rather than changing the current lighten implementation.
> > > > 
> > > > I will do that on skia/trunk
> > > 
> > > Mike, thanks for accepting this patch.
> > > 
> > > So, now I modified this patch so that this patch is now integration from
> Skia
> > > upstream. Brett, could you check this patch?
> > > 
> > > The upstream change was
> > > 
> > > http://code.google.com/p/skia/source/detail?r=159
> > > 
> > > (please note that I didn't introduce all changes from this revision
because
> > > there were actually two changes in the change of the Skia upstream)
> > > 
> > > Thanks!
> > > 
> > > 
> > > > 
> > > > On 2009/04/23 23:00:36, hamaji wrote:
> > > > >