Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1904)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 9309111: Remove initial empty setting of base color for OmniBoxViewViews (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed notification observer Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 3710bfd6bc0b8902cabe3c5f4489c3df531092c8..2fce490a6f56ea4baccbcc25980d6515bb6f8b4b 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -17,7 +17,6 @@
#include "chrome/browser/ui/view_ids.h"
#include "chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
-#include "chrome/common/chrome_notification_types.h"
#include "content/public/browser/web_contents.h"
#include "googleurl/src/gurl.h"
#include "grit/app_locale_settings.h"
@@ -222,15 +221,6 @@ void OmniboxViewViews::Init() {
chromeos::input_method::InputMethodManager::GetInstance()->
AddCandidateWindowObserver(this);
#endif
-
- // Manually invoke SetBaseColor() because TOOLKIT_VIEWS doesn't observe
- // themes.
- SetBaseColor();
-}
-
-void OmniboxViewViews::SetBaseColor() {
- // TODO(oshima): Implement style change.
- NOTIMPLEMENTED();
}
bool OmniboxViewViews::HandleAfterKeyEvent(const views::KeyEvent& event,
@@ -666,16 +656,6 @@ int OmniboxViewViews::OnPerformDrop(const views::DropTargetEvent& event) {
}
////////////////////////////////////////////////////////////////////////////////
-// OmniboxViewViews, content::NotificationObserver implementation:
-
-void OmniboxViewViews::Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- DCHECK(type == chrome::NOTIFICATION_BROWSER_THEME_CHANGED);
- SetBaseColor();
-}
-
-////////////////////////////////////////////////////////////////////////////////
// OmniboxViewViews, views::TextfieldController implementation:
void OmniboxViewViews::ContentsChanged(views::Textfield* sender,

Powered by Google App Engine
This is Rietveld 408576698