Issue 9309098: Handle F6 and F7 (brightness keys) in ash [part 3 of 3].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9309098: Handle F6 and F7 (brightness keys) in ash [part 3 of 3]. (Closed)

Created:
8 years, 10 months ago by Yusuke Sato

Modified:
8 years, 10 months ago

Reviewers:
Elliot Glaysher, Daniel Erat, sky

CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, dhollowa+watch_chromium.org, penghuang+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Handle F6 and F7 (brightness keys) in ash [part 3 of 3]. Support multimedia keys on an external USB keyboard. Since Windows does not define VKs for brightness keys, add new VKEYs to keyboard_codes_posix.h. BUG=110407 TEST=ran aura_shell_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=121394

Patch Set 1 : review #

Patch Set 2 : rebase #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -3 lines)			Patch
M	ash/accelerators/accelerator_controller.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ash/accelerators/accelerator_controller_unittest.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_code_conversion_x.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ui/base/keycodes/keyboard_codes_posix.h	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9309098/13005

8 years, 10 months ago (2012-02-10 01:09:39 UTC) #6

Change committed as 121394

Expand Messages | Collapse Messages