Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 9309083: Remove PreReadImage from base/file_util. (Closed)

Created:
8 years, 10 months ago by Roger McFarlane (Chromium)
Modified:
8 years, 10 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, robertshield, Sigurður Ásgeirsson, chrisha
Visibility:
Public.

Description

Remove PreReadImage from base/file_util. This functionality has been moved to chrome/app. See http://codereview.chromium.org/9235053/ Note that CL 9235053 must be landed BEFORE this one. BUG=chromium:98508 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120761

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -76 lines) Patch
M base/file_util.h View 1 1 chunk +0 lines, -10 lines 0 comments Download
M base/file_util_win.cc View 1 1 chunk +0 lines, -66 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Roger McFarlane (Chromium)
PTAL
8 years, 10 months ago (2012-02-03 17:47:58 UTC) #1
Evan Martin
LGTM I love deleted code! :D
8 years, 10 months ago (2012-02-03 17:48:41 UTC) #2
darin (slow to review)
LGTM2
8 years, 10 months ago (2012-02-03 18:30:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerm@chromium.org/9309083/5001
8 years, 10 months ago (2012-02-07 00:29:47 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-02-07 11:02:33 UTC) #5
Change committed as 120761

Powered by Google App Engine
This is Rietveld 408576698